Diagnose lack of input files

Author: robinkunde

Sources/SwiftDriver/Driver/Driver.swift

@@ -41,11 +41,28 @@ public enum ModuleOutput: Equatable {
 
 /// The Swift driver.
 public struct Driver {
-  enum Error: Swift.Error {
+  public enum Error: Swift.Error, LocalizedError {
     case invalidDriverName(String)
     case invalidInput(String)
-    case subcommandPassedToDriver
+    case noJobsPassedToDriverFromEmptyInputFileList
     case relativeFrontendPath(String)
+    case subcommandPassedToDriver
+
+    public var errorDescription: String? {
+      switch self {
+      case .invalidDriverName(let driverName):
+        return "invalid drive name: \(driverName)"
+      case .invalidInput(let input):
+        return "invalid input: \(input)"
+      case .noJobsPassedToDriverFromEmptyInputFileList:
+        return "no input files were passed and no subsequent jobs were generated for the driver"
+      case .relativeFrontendPath(let path):
+        // TODO: where is this error thrown
+        return "relative frontend path: \(path)"
+      case .subcommandPassedToDriver:
+        return "subcommand passed to driver"
+      }
+    }
   }
 
   /// The set of environment variables that are visible to the driver and
@@ -572,7 +589,7 @@ extension Driver {
     switch driverName {
     case "swift":
       return .interactive
-    case "swiftc":
+    case "swiftc", "swift-driver":
       return .batch
     case "swift-autolink-extract":
       return .autolinkExtract
@@ -604,7 +621,12 @@ extension Driver {
       try printVersion(outputStream: &stderrStream)
     }
 
-    if jobs.isEmpty { return }
+    guard !jobs.isEmpty else {
+      guard !inputFiles.isEmpty else {
+        throw Error.noJobsPassedToDriverFromEmptyInputFileList
+      }
+      return
+    }
 
     let forceResponseFiles = parsedOptions.contains(.driverForceResponseFiles)
 

Sources/swift-driver/main.swift

@@ -52,6 +52,9 @@ do {
   exit(EXIT_FAILURE)
 } catch let diagnosticData as DiagnosticData {
   diagnosticsEngine.emit(.error(diagnosticData))
+} catch let driverError as Driver.Error {
+  print("error: \(driverError.localizedDescription)")
+  exit(EXIT_FAILURE)
 } catch {
   print("error: \(error)")
   exit(EXIT_FAILURE)