Get rid of array slice that was always for the full array

Author: cltnschlosser

Sources/SwiftDriver/Driver/Driver.swift

@@ -241,7 +241,7 @@ public struct Driver {
       throw Error.subcommandPassedToDriver
     }
 
-    var args = try Self.expandResponseFiles(args, fileSystem: fileSystem, diagnosticsEngine: self.diagnosticEngine)[...]
+    var args = try Self.expandResponseFiles(args, fileSystem: fileSystem, diagnosticsEngine: self.diagnosticEngine)
 
     self.driverKind = try Self.determineDriverKind(args: &args)
     self.optionTable = OptionTable()
@@ -581,7 +581,7 @@ extension Driver {
   /// Determine the driver kind based on the command-line arguments, consuming the arguments
   /// conveying this information.
   public static func determineDriverKind(
-    args: inout ArraySlice<String>
+    args: inout [String]
   ) throws -> DriverKind {
     // Get the basename of the driver executable.
     let execRelPath = args.removeFirst()

Tests/SwiftDriverTests/SwiftDriverTests.swift

@@ -58,21 +58,21 @@ final class SwiftDriverTests: XCTestCase {
     func assertArgs(
       _ args: String...,
       parseTo driverKind: DriverKind,
-      leaving remainingArgs: ArraySlice<String>,
+      leaving remainingArgs: [String],
       file: StaticString = #file, line: UInt = #line
     ) throws {
-      var slice = args[...]
-      let result = try Driver.determineDriverKind(args: &slice)
+      var args = args
+      let result = try Driver.determineDriverKind(args: &args)
 
       XCTAssertEqual(result, driverKind, file: file, line: line)
-      XCTAssertEqual(slice, remainingArgs, file: file, line: line)
+      XCTAssertEqual(args, remainingArgs, file: file, line: line)
     }
     func assertArgsThrow(
       _ args: String...,
       file: StaticString = #file, line: UInt = #line
     ) throws {
-      var slice = args[...]
-      XCTAssertThrowsError(try Driver.determineDriverKind(args: &slice))
+      var args = args
+      XCTAssertThrowsError(try Driver.determineDriverKind(args: &args))
     }
 
     try assertArgs("swift", parseTo: .interactive, leaving: [])