Only use and test -target-sdk-name when supported by the frontend

Author: xymus

Sources/SwiftDriver/Jobs/FrontendJobHelpers.swift

@@ -291,7 +291,8 @@ extension Driver {
 
     try toolchain.addPlatformSpecificCommonFrontendOptions(commandLine: &commandLine,
                                                            inputs: &inputs,
-                                                           frontendTargetInfo: frontendTargetInfo)
+                                                           frontendTargetInfo: frontendTargetInfo,
+                                                           driver: self)
   }
 
   mutating func addFrontendSupplementaryOutputArguments(commandLine: inout [Job.ArgTemplate],

Sources/SwiftDriver/Toolchains/DarwinToolchain.swift

@@ -339,7 +339,8 @@ public final class DarwinToolchain: Toolchain {
   public func addPlatformSpecificCommonFrontendOptions(
     commandLine: inout [Job.ArgTemplate],
     inputs: inout [TypedVirtualPath],
-    frontendTargetInfo: FrontendTargetInfo
+    frontendTargetInfo: FrontendTargetInfo,
+    driver: Driver
   ) throws {
     guard let sdkPath = frontendTargetInfo.sdkPath?.path,
           let sdkInfo = getTargetSDKInfo(sdkPath: sdkPath) else { return }
@@ -352,8 +353,10 @@ public final class DarwinToolchain: Toolchain {
       commandLine.append(.flag(sdkInfo.sdkVersion(for: targetVariantTriple).description))
     }
 
-    commandLine.append(.flag("-target-sdk-name"))
-    commandLine.append(.flag(sdkInfo.canonicalName))
+    if driver.isFrontendArgSupported(.targetSdkName) {
+      commandLine.append(.flag(Option.targetSdkName.spelling))
+      commandLine.append(.flag(sdkInfo.canonicalName))
+    }
 
     // We should be able to pass down prebuilt module dir for all other SDKs.
     // For macCatalyst, doing so is specifically necessary because -target-sdk-version

Sources/SwiftDriver/Toolchains/Toolchain.swift

@@ -96,7 +96,8 @@ public protocol Toolchain {
   func addPlatformSpecificCommonFrontendOptions(
     commandLine: inout [Job.ArgTemplate],
     inputs: inout [TypedVirtualPath],
-    frontendTargetInfo: FrontendTargetInfo
+    frontendTargetInfo: FrontendTargetInfo,
+    driver: Driver
   ) throws
 
   var dummyForTestingObjectFormat: Triple.ObjectFormat {get}
@@ -220,7 +221,8 @@ extension Toolchain {
   public func addPlatformSpecificCommonFrontendOptions(
     commandLine: inout [Job.ArgTemplate],
     inputs: inout [TypedVirtualPath],
-    frontendTargetInfo: FrontendTargetInfo
+    frontendTargetInfo: FrontendTargetInfo,
+    driver: Driver
   ) throws {}
 }
 

Tests/SwiftDriverTests/SwiftDriverTests.swift

@@ -3091,10 +3091,12 @@ final class SwiftDriverTests: XCTestCase {
           .flag("-target-sdk-version"),
           .flag("10.15.0")
         ]))
-        XCTAssertTrue(frontendJobs[0].commandLine.contains(subsequence: [
-          .flag("-target-sdk-name"),
-          .flag("macosx10.15"),
-        ]))
+        if driver.isFrontendArgSupported(.targetSdkName) {
+          XCTAssertTrue(frontendJobs[0].commandLine.contains(subsequence: [
+            .flag("-target-sdk-name"),
+            .flag("macosx10.15"),
+          ]))
+        }
         XCTAssertEqual(frontendJobs[1].kind, .link)
         XCTAssertTrue(frontendJobs[1].commandLine.contains(subsequence: [
           .flag("-platform_version"),
@@ -3117,8 +3119,6 @@ final class SwiftDriverTests: XCTestCase {
           .flag("10.15.0"),
           .flag("-target-variant-sdk-version"),
           .flag("13.1.0"),
-          .flag("-target-sdk-name"),
-          .flag("macosx10.15"),
         ]))
         XCTAssertEqual(frontendJobs[1].kind, .link)
         XCTAssertTrue(frontendJobs[1].commandLine.contains(subsequence: [
@@ -3145,10 +3145,14 @@ final class SwiftDriverTests: XCTestCase {
           .flag("-target-sdk-version"),
           .flag("10.15.4"),
           .flag("-target-variant-sdk-version"),
-          .flag("13.4.0"),
-          .flag("-target-sdk-name"),
-          .flag("macosx10.15.4"),
+          .flag("13.4.0")
         ]))
+        if driver.isFrontendArgSupported(.targetSdkName) {
+          XCTAssertTrue(frontendJobs[0].commandLine.contains(subsequence: [
+            .flag("-target-sdk-name"),
+            .flag("macosx10.15.4"),
+          ]))
+        }
         XCTAssertEqual(frontendJobs[1].kind, .link)
         XCTAssertTrue(frontendJobs[1].commandLine.contains(subsequence: [
           .flag("-platform_version"),
@@ -3174,9 +3178,7 @@ final class SwiftDriverTests: XCTestCase {
           .flag("-target-sdk-version"),
           .flag("13.4.0"),
           .flag("-target-variant-sdk-version"),
-          .flag("10.15.4"),
-          .flag("-target-sdk-name"),
-          .flag("macosx10.15.4"),
+          .flag("10.15.4")
         ]))
         XCTAssertEqual(frontendJobs[1].kind, .link)
         XCTAssertTrue(frontendJobs[1].commandLine.contains(subsequence: [