Skip to content

Commit 5fa2596

Browse files
committed
[Explicit Module Builds] Remove dead/incorrect code for handling header inputs of binary module dependencies
As of swiftlang/swift#72067, we instead serialize `.h` inputs directly into binary `.swiftmodule` files, because their clients may not be able to use the dependnecies' corresponding `.pch` files due to a compilation context mismatch. The clients of such binary modules then consume the serialized `.h` files directly, and compile them, implicitly, using explicit module dependencies collected during scan of such header files. Resolves rdar://131261765
1 parent 97b129e commit 5fa2596

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

Sources/SwiftDriver/ExplicitModuleBuilds/ExplicitDependencyBuildPlanner.swift

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -269,12 +269,6 @@ public typealias ExternalTargetModuleDetailsMap = [ModuleDependencyId: ExternalT
269269
if cas != nil && !prebuiltHeaderDependencyPaths.isEmpty {
270270
throw DependencyScanningError.unsupportedConfigurationForCaching("module \(dependencyModule.moduleName) has bridging header dependency")
271271
}
272-
273-
for headerDep in prebuiltHeaderDependencyPaths {
274-
commandLine.appendFlags(["-Xcc", "-include-pch", "-Xcc"])
275-
commandLine.appendPath(VirtualPath.lookup(headerDep.path))
276-
inputs.append(TypedVirtualPath(file: headerDep.path, type: .pch))
277-
}
278272
}
279273
for moduleArtifactInfo in clangDependencyArtifacts {
280274
let clangModulePath =

0 commit comments

Comments
 (0)