Use a Loop Condition Instead of a Filtered Collection

When the set of input files is large, materializing this collection can be expensive. Just use a loop condition.

Author: CodaFi

Sources/SwiftDriver/ExplicitModuleBuilds/ModuleDependencyScanning.swift

@@ -61,7 +61,7 @@ internal extension Driver {
     }
 
     // Pass on the input files
-    commandLine.append(contentsOf: inputFiles.map { .path($0.file)})
+    commandLine.append(contentsOf: inputFiles.map { .path($0.file) })
     return (inputs, commandLine)
   }
 

Sources/SwiftDriver/Jobs/EmitModuleJob.swift

@@ -59,10 +59,8 @@ extension Driver {
 
     commandLine.appendFlags("-frontend", "-emit-module", "-experimental-skip-non-inlinable-function-bodies-without-types")
 
-    let swiftInputFiles = inputFiles.filter { $0.type.isPartOfSwiftCompilation }
-
     // Add the inputs.
-    for input in swiftInputFiles {
+    for input in self.inputFiles where input.type.isPartOfSwiftCompilation {
       commandLine.append(.path(input.file))
       inputs.append(input)
     }