Skip to content

Commit 6fa5db2

Browse files
author
David Ungar
committed
Rm warning, improve a diagnostic
1 parent 117fe24 commit 6fa5db2

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

Sources/SwiftDriver/IncrementalCompilation/IncrementalCompilationState.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ extension IncrementalCompilationState {
443443
fatalError("Dependent \(dependent) does not have dependencies file!")
444444
}
445445
reporter?.report(
446-
"Queuing because of external dependency on newer \(extDep.file?.basename ?? "extDep?")",
446+
"Queuing because of \(forIncrementalExternalDependencies ? "incremental " : "")external dependency on newer \(extDep.file?.basename ?? "extDep?")",
447447
path: dependencySource.typedFile)
448448
externalDependencySources.insert(dependencySource)
449449
}

Sources/SwiftDriver/IncrementalCompilation/ModuleDependencyGraph.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,6 @@ extension ModuleDependencyGraph {
176176
) -> Integrator.Results? {
177177
guard let file = incrementalExternalDependency.file
178178
else {
179-
#warning("right?")
180179
diagnosticEngine.emit(warning: "Cannot get file for externalDependency \(incrementalExternalDependency.fileName)")
181180
return nil
182181
}

0 commit comments

Comments
 (0)