Skip to content

Commit 716e6d5

Browse files
authored
Update IncrementalCompilationTests.swift
Mark the test as throwing and `throw XCTSkip` rather than silently returning as per the review comments.
1 parent ab48712 commit 716e6d5

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

Tests/SwiftDriverTests/IncrementalCompilationTests.swift

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,9 @@ extension IncrementalCompilationTests {
134134
/// Ensure that autolink output file goes with .o directory, to not prevent incremental omission of
135135
/// autolink job.
136136
/// Much of the code below is taking from testLinking(), but uses the output file map code here.
137-
func testAutolinkOutputPath() {
137+
func testAutolinkOutputPath() throws {
138138
#if os(Windows)
139-
// XCTSkip("Driver.init fatalError")
140-
return
139+
throw XCTSkip("Driver.init fatalError")
141140
#else
142141
var env = ProcessEnv.vars
143142
env["SWIFT_DRIVER_TESTS_ENABLE_EXEC_PATH_FALLBACK"] = "1"

0 commit comments

Comments
 (0)