Skip to content

Commit 8271b34

Browse files
author
David Ungar
committed
Address review comments.
# Conflicts: # Sources/SwiftDriver/IncrementalCompilation/ModuleDependencyGraph.swift
1 parent 5786b73 commit 8271b34

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

Sources/SwiftDriver/IncrementalCompilation/ModuleDependencyGraph.swift

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,10 +207,9 @@ extension ModuleDependencyGraph {
207207
let diags = info.diagnosticEngine
208208
var allFound = true
209209
for input in info.inputFiles {
210-
if let source = ofm.getDependencySource(for: input, diagnosticEngine: diags) {
210+
if let source = ofm.dependencySource(for: input, diagnosticEngine: diags) {
211211
inputDependencySourceMap.addEntry(input, source, for: purpose)
212-
}
213-
else {
212+
} else {
214213
// Don't break in order to report all failures.
215214
allFound = false
216215
}
@@ -219,7 +218,7 @@ extension ModuleDependencyGraph {
219218
}
220219
}
221220
extension OutputFileMap {
222-
fileprivate func getDependencySource(
221+
fileprivate func dependencySource(
223222
for sourceFile: TypedVirtualPath,
224223
diagnosticEngine: DiagnosticsEngine
225224
) -> DependencySource? {
@@ -343,8 +342,7 @@ extension ModuleDependencyGraph {
343342
) -> TransitivelyInvalidatedInputSet? {
344343
var invalidatedInputs = TransitivelyInvalidatedInputSet()
345344
for invalidatedSwiftDeps in collectSwiftDepsUsingInvalidated(nodes: directlyInvalidatedNodes) {
346-
guard let invalidatedInput = getNeededInput(for: invalidatedSwiftDeps)
347-
else {
345+
guard let invalidatedInput = input(neededFor: invalidatedSwiftDeps) else {
348346
return nil
349347
}
350348
invalidatedInputs.insert(invalidatedInput)

0 commit comments

Comments
 (0)