Skip to content

Commit 955df38

Browse files
committed
Re-enable 'testModuleAliasingPrebuiltWithScanDeps'.
It appears the test setup resulted in us being unable to find modules when passing them as explicit dependencies to depending compiler invocations. Setting an explicit module cache path helps with that. Resolves rdar://88073675
1 parent 1f2f5e9 commit 955df38

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Tests/SwiftDriverTests/ExplicitModuleBuildTests.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -603,8 +603,6 @@ final class ExplicitModuleBuildTests: XCTestCase {
603603

604604

605605
func testModuleAliasingPrebuiltWithScanDeps() throws {
606-
// rdar://88073675
607-
throw XCTSkip("Skipping, known failure (rdar://88073675).")
608606
try withTemporaryDirectory { path in
609607
let sdkArgumentsForTesting = (try? Driver.sdkArgumentsForTesting()) ?? []
610608
let (stdLibPath, shimsPath, _, _) = try getDriverArtifactsForScanning()
@@ -625,6 +623,7 @@ final class ExplicitModuleBuildTests: XCTestCase {
625623
"Bar",
626624
"-emit-module",
627625
"-emit-module-path", moduleBarPath,
626+
"-module-cache-path", path.nativePathString(escaped: true),
628627
"-I", stdLibPath.nativePathString(escaped: true),
629628
"-I", shimsPath.nativePathString(escaped: true),
630629
] + sdkArgumentsForTesting,

0 commit comments

Comments
 (0)