Merge pull request #690 from davidungar/better-sorting-by-command-line-order

David Ungar · web-flow · commit 9efdc63516d5 · 2021-06-01T19:58:44.000-07:00
[Incremental] More efficient sorting
diff --git a/Sources/SwiftDriver/IncrementalCompilation/FirstWaveComputer.swift b/Sources/SwiftDriver/IncrementalCompilation/FirstWaveComputer.swift
@@ -192,8 +192,10 @@ extension IncrementalCompilationState.FirstWaveComputer {
     return skippedInputs
   }
 
-  private func sortByCommandLineOrder(_ inputs: Set<TypedVirtualPath>) -> [TypedVirtualPath] {
-    inputFiles.filter (inputs.contains)
+  private func sortByCommandLineOrder(
+    _ inputs: Set<TypedVirtualPath>
+  ) -> LazyFilterSequence<[TypedVirtualPath]> {
+      inputFiles.lazy.filter(inputs.contains)
   }
 
   /// Encapsulates information about an input the driver has determined has

Original file line number	Diff line number	Diff line change
`@@ -192,8 +192,10 @@ extension IncrementalCompilationState.FirstWaveComputer {`
`192`	`192`	`return skippedInputs`
`193`	`193`	`}`
`194`	`194`
`195`		`- private func sortByCommandLineOrder(_ inputs: Set<TypedVirtualPath>) -> [TypedVirtualPath] {`
`196`		`- inputFiles.filter (inputs.contains)`
	`195`	`+ private func sortByCommandLineOrder(`
	`196`	`+ _ inputs: Set<TypedVirtualPath>`
	`197`	`+ ) -> LazyFilterSequence<[TypedVirtualPath]> {`
	`198`	`+ inputFiles.lazy.filter(inputs.contains)`
`197`	`199`	`}`
`198`	`200`
`199`	`201`	`/// Encapsulates information about an input the driver has determined has`