Add a unit test for invoking subcommands with response files

Author: owenv

Sources/SwiftDriver/Driver/Driver.swift

@@ -476,12 +476,8 @@ extension Driver {
     #if !os(macOS) && !os(Linux)
       #warning("Response file tokenization unimplemented for platform; behavior may be incorrect")
     #endif
-    var array: [String] = []
-    array.reserveCapacity(256)
-    content.split { $0 == "\n" || $0 == "\r\n" }
-           .map { tokenizeResponseFileLine($0) }
-           .forEach { array += $0 }
-    return array
+    return content.split { $0 == "\n" || $0 == "\r\n" }
+           .flatMap { tokenizeResponseFileLine($0) }
   }
 
   /// Recursively expands the response files.

Tests/SwiftDriverTests/SwiftDriverTests.swift

@@ -482,6 +482,51 @@ final class SwiftDriverTests: XCTestCase {
       XCTAssertEqual(escapingArgs, ["swift", "--driver-mode=swiftc", "-v","the end"])
     }
   }
+
+  func testUsingResponseFiles() throws {
+    let manyArgs = (1...500_000).map { "-DTEST_\($0)" }
+    // Needs response file
+    do {
+      var driver = try Driver(args: ["swift"] + manyArgs + ["foo.swift"])
+      let jobs = try driver.planBuild()
+      XCTAssertTrue(jobs.count == 1 && jobs[0].kind == .interpret)
+      let interpretJob = jobs[0]
+      let resolver = try ArgsResolver()
+      let resolvedArgs: [String] = try resolver.resolveArgumentList(for: interpretJob, forceResponseFiles: false)
+      XCTAssertTrue(resolvedArgs.count == 2)
+      XCTAssertEqual(resolvedArgs[1].first, "@")
+      let responseFilePath = try AbsolutePath(validating: String(resolvedArgs[1].dropFirst()))
+      let contents = try localFileSystem.readFileContents(responseFilePath).description
+      XCTAssertTrue(contents.hasPrefix("-frontend\n-interpret\nfoo.swift"))
+      XCTAssertTrue(contents.contains("-D\nTEST_500000"))
+      XCTAssertTrue(contents.contains("-D\nTEST_1"))
+    }
+    // Forced response file
+    do {
+      var driver = try Driver(args: ["swift"] + ["foo.swift"])
+      let jobs = try driver.planBuild()
+      XCTAssertTrue(jobs.count == 1 && jobs[0].kind == .interpret)
+      let interpretJob = jobs[0]
+      let resolver = try ArgsResolver()
+      let resolvedArgs: [String] = try resolver.resolveArgumentList(for: interpretJob, forceResponseFiles: true)
+      XCTAssertTrue(resolvedArgs.count == 2)
+      XCTAssertEqual(resolvedArgs[1].first, "@")
+      let responseFilePath = try AbsolutePath(validating: String(resolvedArgs[1].dropFirst()))
+      let contents = try localFileSystem.readFileContents(responseFilePath).description
+      XCTAssertTrue(contents.hasPrefix("-frontend\n-interpret\nfoo.swift"))
+    }
+
+    // No response file
+    do {
+      var driver = try Driver(args: ["swift"] + ["foo.swift"])
+      let jobs = try driver.planBuild()
+      XCTAssertTrue(jobs.count == 1 && jobs[0].kind == .interpret)
+      let interpretJob = jobs[0]
+      let resolver = try ArgsResolver()
+      let resolvedArgs: [String] = try resolver.resolveArgumentList(for: interpretJob, forceResponseFiles: false)
+      XCTAssertFalse(resolvedArgs.map { $0.hasPrefix("@") }.reduce(false){ $0 || $1 })
+    }
+  }
 
   func testLinking() throws {
     var env = ProcessEnv.vars