Pass down the no-verify flag to the frontend invocations

The flag -no-verify-emitted-module-interface tells the driver to skip verifying the swiftinterfaces emitted by the compiler. Let's pass it down to the frontend as well and so it can write it down in the skipped swiftinterface. This will help understand them from the reader side.

rdar://120445669

Author: xymus

Sources/SwiftDriver/Jobs/FrontendJobHelpers.swift

@@ -420,6 +420,15 @@ extension Driver {
       }
     }
 
+    // Pass along -no-verify-emitted-module-interface only if it's effective.
+    // Assume verification by default as we want to know only when the user skips
+    // the verification.
+    if !parsedOptions.hasFlag(positive: .verifyEmittedModuleInterface,
+                              negative: .noVerifyEmittedModuleInterface,
+                              default: true) {
+      commandLine.appendFlag("-no-verify-emitted-module-interface")
+    }
+
     // Repl Jobs shouldn't include -module-name.
     if compilerMode != .repl && compilerMode != .intro {
       commandLine.appendFlags("-module-name", moduleOutputInfo.name)

Tests/SwiftDriverTests/SwiftDriverTests.swift

@@ -5590,6 +5590,8 @@ final class SwiftDriverTests: XCTestCase {
                                      "-no-verify-emitted-module-interface"], env: envVars)
       let plannedJobs = try driver.planBuild()
       XCTAssertEqual(plannedJobs.count, 2)
+      let emitJob = try plannedJobs.findJob(.emitModule)
+      XCTAssertTrue(emitJob.commandLine.contains("-no-verify-emitted-module-interface"))
     }
 
     // Disabled by default in merge-module
@@ -5628,6 +5630,8 @@ final class SwiftDriverTests: XCTestCase {
       XCTAssertTrue(verifyJob.inputs.count == 1)
       XCTAssertTrue(verifyJob.inputs[0] == emitInterfaceOutput[0])
       XCTAssertTrue(verifyJob.commandLine.contains(.path(emitInterfaceOutput[0].file)))
+      XCTAssertFalse(emitJob.commandLine.contains("-no-verify-emitted-module-interface"))
+      XCTAssertFalse(emitJob.commandLine.contains("-verify-emitted-module-interface"))
     }
 
     // Whole-module
@@ -5650,6 +5654,19 @@ final class SwiftDriverTests: XCTestCase {
       XCTAssertTrue(verifyJob.commandLine.contains(.path(emitInterfaceOutput[0].file)))
     }
 
+    // Test the `-no-verify-emitted-module-interface` flag with whole-module
+    do {
+      var driver = try Driver(args: ["swiftc", "foo.swift", "-emit-module", "-module-name",
+                                     "foo", "-emit-module-interface",
+                                     "-enable-library-evolution",
+                                     "-whole-module-optimization",
+                                     "-no-verify-emitted-module-interface"], env: envVars)
+      let plannedJobs = try driver.planBuild()
+      XCTAssertEqual(plannedJobs.count, 1)
+      let compileJob = try plannedJobs.findJob(.compile)
+      XCTAssertTrue(compileJob.commandLine.contains("-no-verify-emitted-module-interface"))
+    }
+
     // Enabled by default when the library-level is api.
     do {
       var driver = try Driver(args: ["swiftc", "foo.swift", "-emit-module", "-module-name",
@@ -5672,6 +5689,8 @@ final class SwiftDriverTests: XCTestCase {
       let plannedJobs = try driver.planBuild()
       XCTAssertEqual(plannedJobs.count, 1)
       XCTAssertEqual(plannedJobs[0].kind, .compile)
+      let compileJob = try plannedJobs.findJob(.compile)
+      XCTAssertFalse(compileJob.commandLine.contains("-no-verify-emitted-module-interface"))
     }
 
     // The flag -check-api-availability-only is not passed down to the verify job.