Skip to content

Commit da1cd23

Browse files
committed
Remove incrementalCompilationState from ToolExecutionDelegate.
The incremental state is never used/referenced from this delegate and the existence of this reference may complicate things with respect to the incremental state's lifetime. rdar://95990331
1 parent 3e802a8 commit da1cd23

File tree

3 files changed

+0
-7
lines changed

3 files changed

+0
-7
lines changed

Sources/SwiftDriver/Driver/Driver.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1409,7 +1409,6 @@ extension Driver {
14091409
return ToolExecutionDelegate(
14101410
mode: mode,
14111411
buildRecordInfo: buildRecordInfo,
1412-
incrementalCompilationState: incrementalCompilationState,
14131412
showJobLifecycle: showJobLifecycle,
14141413
argsResolver: executor.resolver,
14151414
diagnosticEngine: diagnosticEngine)

Sources/SwiftDriver/Driver/ToolExecutionDelegate.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ import Glibc
4242

4343
public let mode: Mode
4444
public let buildRecordInfo: BuildRecordInfo?
45-
public let incrementalCompilationState: IncrementalCompilationState?
4645
public let showJobLifecycle: Bool
4746
public let diagnosticEngine: DiagnosticsEngine
4847
public var anyJobHadAbnormalExit: Bool = false
@@ -53,13 +52,11 @@ import Glibc
5352

5453
@_spi(Testing) public init(mode: ToolExecutionDelegate.Mode,
5554
buildRecordInfo: BuildRecordInfo?,
56-
incrementalCompilationState: IncrementalCompilationState?,
5755
showJobLifecycle: Bool,
5856
argsResolver: ArgsResolver,
5957
diagnosticEngine: DiagnosticsEngine) {
6058
self.mode = mode
6159
self.buildRecordInfo = buildRecordInfo
62-
self.incrementalCompilationState = incrementalCompilationState
6360
self.showJobLifecycle = showJobLifecycle
6461
self.diagnosticEngine = diagnosticEngine
6562
self.argsResolver = argsResolver

Tests/SwiftDriverTests/ParsableMessageTests.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,6 @@ final class ParsableMessageTests: XCTestCase {
154154
let args : [String] = try resolver.resolveArgumentList(for: compileJob, forceResponseFiles: false)
155155
let toolDelegate = ToolExecutionDelegate(mode: .parsableOutput,
156156
buildRecordInfo: nil,
157-
incrementalCompilationState: nil,
158157
showJobLifecycle: false,
159158
argsResolver: resolver,
160159
diagnosticEngine: DiagnosticsEngine())
@@ -247,7 +246,6 @@ final class ParsableMessageTests: XCTestCase {
247246
args = try resolver.resolveArgumentList(for: compileJob!, forceResponseFiles: false)
248247
toolDelegate = ToolExecutionDelegate(mode: .parsableOutput,
249248
buildRecordInfo: nil,
250-
incrementalCompilationState: nil,
251249
showJobLifecycle: false,
252250
argsResolver: resolver,
253251
diagnosticEngine: DiagnosticsEngine())
@@ -325,7 +323,6 @@ final class ParsableMessageTests: XCTestCase {
325323
forceResponseFiles: false)
326324
toolDelegate = ToolExecutionDelegate(mode: .parsableOutput,
327325
buildRecordInfo: nil,
328-
incrementalCompilationState: nil,
329326
showJobLifecycle: false,
330327
argsResolver: resolver,
331328
diagnosticEngine: DiagnosticsEngine())

0 commit comments

Comments
 (0)