Skip to content

Commit e9253c8

Browse files
authored
Merge pull request #774 from artemcm/DisableVerboseImmediateAS
Disable `testVerboseImmediate` test on Apple Silicon
2 parents 641d954 + 31094ea commit e9253c8

File tree

1 file changed

+22
-16
lines changed

1 file changed

+22
-16
lines changed

Tests/SwiftDriverTests/SwiftDriverTests.swift

Lines changed: 22 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -769,21 +769,21 @@ final class SwiftDriverTests: XCTestCase {
769769
XCTAssertFalse(plannedJobs[2].commandLine.contains(.flag("-emit-dependencies-path")))
770770
XCTAssertFalse(plannedJobs[2].commandLine.contains(.flag("-serialize-diagnostics-path")))
771771
}
772-
772+
773773
func testReferenceDependencies() throws {
774774
var driver = try Driver(args: ["swiftc", "foo.swift", "-incremental"])
775775
let plannedJobs = try driver.planBuild()
776776
XCTAssertTrue(plannedJobs[0].kind == .compile)
777777
XCTAssertTrue(plannedJobs[0].commandLine.contains(.flag("-emit-reference-dependencies-path")))
778778
}
779-
779+
780780
func testDuplicateName() throws {
781781
assertDiagnostics { diagnosticsEngine, verify in
782782
_ = try? Driver(args: ["swiftc", "-c", "foo.swift", "foo.swift"], diagnosticsEngine: diagnosticsEngine)
783783
verify.expect(.error("filename \"foo.swift\" used twice: 'foo.swift' and 'foo.swift'"))
784784
verify.expect(.note("filenames are used to distinguish private declarations with the same name"))
785785
}
786-
786+
787787
assertDiagnostics { diagnosticsEngine, verify in
788788
_ = try? Driver(args: ["swiftc", "-c", "foo.swift", "foo/foo.swift"], diagnosticsEngine: diagnosticsEngine)
789789
verify.expect(.error("filename \"foo.swift\" used twice: 'foo.swift' and 'foo/foo.swift'"))
@@ -1235,7 +1235,7 @@ final class SwiftDriverTests: XCTestCase {
12351235
XCTAssertFalse(cmd.contains(.flag("-dylib")))
12361236
XCTAssertFalse(cmd.contains(.flag("-shared")))
12371237
}
1238-
1238+
12391239
do {
12401240
// lto linking
12411241
// Locating relevant libraries is dependent on being a macOS host
@@ -1258,7 +1258,7 @@ final class SwiftDriverTests: XCTestCase {
12581258
var driver3 = try Driver(args: commonArgs + ["-emit-executable", "-target", "x86_64-unknown-linux", "-lto=llvm-full"], env: env)
12591259
let plannedJobs3 = try driver3.planBuild()
12601260
XCTAssertFalse(plannedJobs3.contains(where: { $0.kind == .autolinkExtract }))
1261-
1261+
12621262
let compileJob3 = try XCTUnwrap(plannedJobs3.first(where: { $0.kind == .compile }))
12631263
XCTAssertTrue(compileJob3.outputs.contains { $0.file.basename.hasSuffix(".bc") })
12641264

@@ -1630,14 +1630,14 @@ final class SwiftDriverTests: XCTestCase {
16301630
#endif
16311631
}
16321632
}
1633-
1633+
16341634
func testSanitizerRecoverArgs() throws {
16351635
let commonArgs = ["swiftc", "foo.swift", "bar.swift",]
16361636
do {
16371637
// address sanitizer + address sanitizer recover
16381638
var driver = try Driver(args: commonArgs + ["-sanitize=address", "-sanitize-recover=address"])
16391639
let plannedJobs = try driver.planBuild().removingAutolinkExtractJobs()
1640-
1640+
16411641
XCTAssertEqual(plannedJobs.count, 3)
16421642

16431643
let compileJob = plannedJobs[0]
@@ -2598,7 +2598,7 @@ final class SwiftDriverTests: XCTestCase {
25982598
return
25992599
}
26002600
}
2601-
2601+
26022602
XCTAssertThrowsError(try Driver(args: ["swiftc", "-c", "-static-stdlib", "-target", "x86_64-apple-macosx10.14",
26032603
"foo.swift"])) { error in
26042604
guard case DarwinToolchain.ToolchainValidationError.argumentNotSupported("-static-stdlib") = error else {
@@ -2614,7 +2614,7 @@ final class SwiftDriverTests: XCTestCase {
26142614
return
26152615
}
26162616
}
2617-
2617+
26182618
XCTAssertThrowsError(try Driver(args: ["swiftc", "-c", "-target", "x86_64-apple-macosx10.14", "-experimental-cxx-stdlib", "libstdc++",
26192619
"foo.swift"])) { error in
26202620
guard case DarwinToolchain.ToolchainValidationError.darwinOnlySupportsLibCxx = error else {
@@ -3452,7 +3452,7 @@ final class SwiftDriverTests: XCTestCase {
34523452
XCTAssertFalse(jobs[0].commandLine.contains("-wmo"))
34533453
XCTAssertTrue(jobs[0].commandLine.contains("-dump-ast"))
34543454
}
3455-
3455+
34563456
try assertDriverDiagnostics(args: ["swiftc", "-index-file", "-dump-ast",
34573457
"foo.swift",
34583458
"-index-file-path", "foo.swift",
@@ -3580,7 +3580,7 @@ final class SwiftDriverTests: XCTestCase {
35803580
do {
35813581
struct MockExecutor: DriverExecutor {
35823582
let resolver: ArgsResolver
3583-
3583+
35843584
func execute(job: Job, forceResponseFiles: Bool, recordedInputModificationDates: [TypedVirtualPath : Date]) throws -> ProcessResult {
35853585
return ProcessResult(arguments: [], environment: [:], exitStatus: .terminated(code: 0), output: .success(Array("bad JSON".utf8)), stderrOutput: .success([]))
35863586
}
@@ -3728,6 +3728,12 @@ final class SwiftDriverTests: XCTestCase {
37283728
}
37293729

37303730
func testVerboseImmediateMode() throws {
3731+
#if os(macOS) && arch(arm64)
3732+
// Temporarily disabled on Apple Silicon
3733+
// rdar://80558898
3734+
throw XCTSkip()
3735+
#endif
3736+
37313737
// There is nothing particularly macOS-specific about this test other than
37323738
// the use of some macOS-specific XCTest functionality to determine the
37333739
// test bundle that contains the swift-driver executable.
@@ -3842,7 +3848,7 @@ final class SwiftDriverTests: XCTestCase {
38423848
XCTAssertEqual(plannedJobs.map(\.kind), [.compile, .link])
38433849
XCTAssertTrue(plannedJobs[1].commandLine.contains("-lto_library"))
38443850
}
3845-
3851+
38463852
do {
38473853
var driver = try Driver(args: ["swiftc", "foo.swift", "-lto=llvm-thin", "-lto-library", "/foo/libLTO.dylib", "-target", "x86_64-apple-macos11.0"])
38483854
let plannedJobs = try driver.planBuild()
@@ -3851,14 +3857,14 @@ final class SwiftDriverTests: XCTestCase {
38513857
XCTAssertTrue(plannedJobs[1].commandLine.contains("-lto_library"))
38523858
XCTAssertTrue(plannedJobs[1].commandLine.contains(.path(try VirtualPath(path: "/foo/libLTO.dylib"))))
38533859
}
3854-
3860+
38553861
do {
38563862
var driver = try Driver(args: ["swiftc", "foo.swift", "-lto=llvm-full", "-target", "x86_64-apple-macos11.0"])
38573863
let plannedJobs = try driver.planBuild()
38583864
XCTAssertEqual(plannedJobs.map(\.kind), [.compile, .link])
38593865
XCTAssertTrue(plannedJobs[1].commandLine.contains("-lto_library"))
38603866
}
3861-
3867+
38623868
do {
38633869
var driver = try Driver(args: ["swiftc", "foo.swift", "-lto=llvm-full", "-lto-library", "/foo/libLTO.dylib", "-target", "x86_64-apple-macos11.0"])
38643870
let plannedJobs = try driver.planBuild()
@@ -3867,7 +3873,7 @@ final class SwiftDriverTests: XCTestCase {
38673873
XCTAssertTrue(plannedJobs[1].commandLine.contains("-lto_library"))
38683874
XCTAssertTrue(plannedJobs[1].commandLine.contains(.path(try VirtualPath(path: "/foo/libLTO.dylib"))))
38693875
}
3870-
3876+
38713877
do {
38723878
var driver = try Driver(args: ["swiftc", "foo.swift", "-target", "x86_64-apple-macos11.0"])
38733879
let plannedJobs = try driver.planBuild()
@@ -4721,7 +4727,7 @@ final class SwiftDriverTests: XCTestCase {
47214727
XCTAssert(jobs.count == 1)
47224728
XCTAssertEqual(jobs.first!.tool.name, "/usr/bin/nonexistent-swift-help")
47234729
}
4724-
4730+
47254731
func testSourceInfoFileEmitOption() throws {
47264732
// implicit
47274733
do {

0 commit comments

Comments
 (0)