Upgrade Swift Argument Parser to version 1.1.2 #1106
Conversation
|
I'm happy to see this happen, but please make sure that you do the necessary associated work for Windows for this. This is going to require that we update swiftlang/swift-installer-scripts#91 and get that merged along with updating update-checkout-config.json in apple/swift. Furthermore, we will also need to coordinate a change in compnerd/swift-build to update the official (Windows) builds. 1.1.2 merges the ToolInfo library which will require that the installers are updated for Windows otherwise this change will break the Windows builds. BTW, the order is missing preliminary steps - you need to start at apple/swift and propagate through, and include swift-installer-scripts as well. |
|
@compnerd Sounds good, I will give it a shot. Thanks! |
|
@compnerd I've created the apple/swift PR you suggested. Let me know if there are any other specific tasks I can do. I don't have much familiarity with the Windows side of things, so I would need a bit more direction/hand-holding in that area. |
|
Okay; I've kicked off toolchain build tests to verify that the toolchain build is not impacted by this. The Windows side of things here is just that we need to update the manifest for the files that are distributed (swiftlang/swift-installer-scripts#91). The official builds use a slightly different build process and that will need to be updated to checkout the correct version as well. |
|
Closing as superseded by #1218 |
This PR upgrades the Swift Argument Parser dependency to version 1.1.2. This is the latest version of the dependency and supports new features like async/await via the
AsyncParsableCommandtype.In order to upgrade this dependency, it must also be upgraded in swift-package-manager and sourcekit-lsp.
I believe the correct order to merge these PRs would be: