Skip to content

Make -e flag 'separate', instead of 'joinedOrSeparate' #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Dec 12, 2022

Update Options.swift to bring in a change to make -e 'separate', instead of 'joinedOrSeparate'.
From: swiftlang/swift#62526

Mainly to bring in a change to make `-e` 'separate', instead of 'joinedOrSeparate'
@artemcm artemcm requested a review from beccadax December 12, 2022 18:47
@artemcm
Copy link
Contributor Author

artemcm commented Dec 12, 2022

@swift-ci test

@beccadax
Copy link
Contributor

I'm out and cannot properly review this, but I'm not conceptually opposed to making -e separate-only if it's interfering with other options. (Is the fact that it's interfering a bug in the argument-processing code, though? I'd expect that to use a longest-prefix match.)

@artemcm
Copy link
Contributor Author

artemcm commented Dec 12, 2022

Even if we can improve our argument parsing logic in the short term, it's worth landing this change for now to fix a broken behavior.

@artemcm artemcm merged commit 960296d into swiftlang:main Dec 13, 2022
@artemcm artemcm deleted the SeparateDashEOnly branch December 13, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants