Skip to content

Use aligned branches for dependencies #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2023
Merged

Use aligned branches for dependencies #1315

merged 1 commit into from
Mar 24, 2023

Conversation

neonichu
Copy link
Contributor

No description provided.

@neonichu neonichu self-assigned this Mar 23, 2023
@neonichu neonichu requested a review from artemcm March 23, 2023 17:48
@neonichu
Copy link
Contributor Author

@swift-ci please test

artemcm
artemcm requested changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is still targeting main?

@neonichu neonichu changed the base branch from main to release/5.9 March 23, 2023 17:53
@neonichu
Copy link
Contributor Author

This PR is still targeting main?

Good catch, fixed.

@neonichu
Copy link
Contributor Author

Is there a reason why the Windows build is significantly different from Linux/macOS? Seems like it is maybe building the entire toolchain?

@neonichu neonichu merged commit ceb48b5 into swiftlang:release/5.9 Mar 24, 2023
@neonichu neonichu deleted the use-aligned-branches branch March 24, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

Assignees

@neonichu neonichu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neonichu @artemcm