Skip to content

Mark more types and Driver state as internal/@_spi(Testing) #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

Mark more types and Driver state as internal/@_spi(Testing) #261

merged 1 commit into from
Sep 22, 2020

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Sep 17, 2020

No description provided.

cltnschlosser
cltnschlosser reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@cltnschlosser cltnschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference/benefit of using spi over internal and @testable?

@artemcm
Copy link
Contributor Author

artemcm commented Sep 18, 2020

What's the difference/benefit of using spi over internal and @testable?

One of the key benefits is that @testable is not compatible with textual interfaces and we would really like to build SwiftDriver with library-evolution quite soon. Still using @testable would mean building twice, once for testing and then again for distribution.

A little bit more reasoning here:
https://forums.swift.org/t/the-future-of-testable/9655/14

@artemcm
Copy link
Contributor Author

artemcm commented Sep 18, 2020

@swift-ci please test

owenv
owenv approved these changes Sep 19, 2020
View reviewed changes
Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@artemcm
Copy link
Contributor Author

artemcm commented Sep 22, 2020

@swift-ci please test

@artemcm artemcm merged commit c605132 into swiftlang:master Sep 22, 2020
@artemcm artemcm deleted the LessAPI branch January 20, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cltnschlosser cltnschlosser cltnschlosser left review comments

@owenv owenv owenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemcm @cltnschlosser @owenv