Handle all FileTypes in OutputFileMap #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream
sjavora
changed the title
FileTypes in OutputFileMap
|
Hey @DougGregor - could someone please take a look at this? I'd request a review, but the button doesn't seem to be there... |
|
The approach looks good here, I've got one small nitpick though. |
…fo. Fix some typos.
sjavora
force-pushed
the
there-can-be-only-one-filetype
branch
from
dcf1bc8 to
4ceee16
Compare
|
@swift-ci please test |
harlanhaskins
approved these changes
Nov 20, 2019
|
@swift-ci please test |
|
Thanks, @sjavora! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the specific properties in
Entrywith a dictionary keyed byFileTypeand adds a custom implementation ofCodable.Originally, I wanted to just use
FileType'sdescriptionproperty, but some of the cases just returnrawValue, which is not compatible in all cases ("o" vs "object", in particular). Instead I added thenameproperty with values from FileTypes.def. While there, I noticed thatFileTypedoesn't currently have a case forswiftsourceinfo, so I added that as well.