Skip to content

[Incremental] Mimic legacy for testing, can omit argsHash from build record and it still matches. #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2020
Merged

[Incremental] Mimic legacy for testing, can omit argsHash from build record and it still matches. #412

merged 2 commits into from
Dec 13, 2020

Conversation

davidungar
Copy link
Contributor

@davidungar davidungar commented Dec 11, 2020 •
edited
Loading

Legacy test driver-show-incremental-arguments-fine.swift requires this.
Same applies to build date.

@davidungar davidungar requested review from owenv and artemcm December 11, 2020 23:03
@davidungar
Copy link
Contributor Author

@swift-ci please test

@davidungar
Copy link
Contributor Author

@swift-ci please test

@davidungar davidungar merged commit 3812ddd into swiftlang:main Dec 13, 2020
@davidungar davidungar deleted the buildrec-match2 branch January 29, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenv owenv owenv approved these changes

@artemcm artemcm Awaiting requested review from artemcm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidungar @owenv