[DNM Incremental] Start of cross-module incrementality #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swit-ci please test |
CodaFi
approved these changes
Feb 3, 2021
|
@swift-ci test |
added 7 commits
February 3, 2021 09:51
Fix tests after extra message
davidungar
force-pushed
the
start-integration-3
branch
from
f47d6ca to
12f0bef
Compare
|
@swift-ci test |
|
@swift-ci test |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates incrementalExternalDependencies.
Unimplemented/Broken:
Does not write ModuleDepGraph or try to read it instead of swiftDeps. Probably doesn't do the right thing if it did read ModuleDepGraph.
Does not do the right thing when importing a module with incrementalExternalDependencies when running with -enable-incremental-cross-module-etc turned off.
Implemented:
Reads incrementalExternalDependencies and integrates the contents of the swiftmodule files, running to a fixpoint.
Causes anything depended upon them to be marked as dirty, since right now there is no prior ModuleDepGraph.