-
Notifications
You must be signed in to change notification settings - Fork 206
Add support for Clang module emission via -emit-pcm #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
@allevato you might be interested in this |
@cltnschlosser mind reviewing, since you seem to also be hacking on this now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about spelling, but otherwise this looks fine to me.
/// bridging header. | ||
/// | ||
/// This is typically used only when precompiling the bridging header. | ||
case parsed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On further inspection, the emit-pch job doesn't even use -import-objc-header
. So parsed isn't needed. I'll have another PR soon to fix up issues I'm finding while doing integration testing.
I like this enum though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
@swift-ci please test |
1 similar comment
@swift-ci please test |
Merge pull request apple#48 from DougGregor/emit-pcm
Teach the driver to emit Clang modules based on the with
-emit-pcm
command-line argument, where the input is the module map.