Skip to content

Add support for Clang module emission via -emit-pcm #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2020

Conversation

DougGregor
Copy link
Member

Teach the driver to emit Clang modules based on the with -emit-pcm command-line argument, where the input is the module map.

@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@allevato you might be interested in this

@DougGregor
Copy link
Member Author

@cltnschlosser mind reviewing, since you seem to also be hacking on this now?

Copy link
Contributor

@beccadax beccadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about spelling, but otherwise this looks fine to me.

/// bridging header.
///
/// This is typically used only when precompiling the bridging header.
case parsed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On further inspection, the emit-pch job doesn't even use -import-objc-header. So parsed isn't needed. I'll have another PR soon to fix up issues I'm finding while doing integration testing.

I like this enum though.

Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@DougGregor
Copy link
Member Author

@swift-ci please test

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit 4b35f2e into swiftlang:master Jan 4, 2020
@DougGregor DougGregor deleted the emit-pcm branch January 4, 2020 05:08
fengjixuchui referenced this pull request in fengjixuchui/swift-driver Jan 4, 2020
Merge pull request apple#48 from DougGregor/emit-pcm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants