Forward -print-target-info to the frontend, begin refactoring planning for simple driver invocations #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
approved these changes
Jan 19, 2020
|
@swift-ci please test |
fengjixuchui
referenced
this pull request
in fengjixuchui/swift-driver
Jan 19, 2020
Merge pull request apple#58 from owenv/print_target_info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-print-target-infoimplementation itself is pretty straightforward. The refactor is a little more interesting, I pulled theplanBuildcall out ofDriver.run. Now, all clients are expected to callplanBuildfor a list of jobs they can hand off toDriver.runor schedule themselves. I also pulled-versionand-print-target-infohandling out ofrunand into the build planning stage. This gives clients more control over executing them in case they want to do something like capture the output. It's not yet clear if we want to do something similar for printing help or forwarding toswift-indent/swift-autolink-extract, I've left that logic alone for now.