Skip to content

Revert "cmake: set up build-script support for swift-build-sdk-interfaces" #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

Reverts #590

This seems to have regressed the Windows port.

@compnerd compnerd requested a review from nkcsgexi April 11, 2021 19:12
@compnerd
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix this instead of reverting since you have the setup?

@compnerd
Copy link
Member Author

Well, its unclear if this code even makes sense on other platforms - I think it makes some sense to revert for the time being. It will be a pretty invasive change to get this fixed.

@nkcsgexi nkcsgexi closed this Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants