PrebuiltModuleGen: teach the tool to dump a .dot file for module dependency visualization #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
artemcm
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Very nice!
We have something similar in SwiftPM:
https://github.com/apple/swift-package-manager/blob/main/Sources/LLBuildManifest/DOTManifestSerializer.swift
But this will be super useful also.
My only comment is that this looks like it'd be handy for general debugging with explicit module builds so perhaps we can make the dot-emission routine more accessible?
| @@ -283,14 +283,68 @@ extension Driver { | |||
| ) | |||
| } | |||
|
|
|||
|
|
|||
| func dumpDotGraph(_ graph: InterModuleDependencyGraph, _ path: AbsolutePath, _ includingPCM: Bool) throws { | |||
There was a problem hiding this comment.
Should we make this an InterModuleDependencyGraph extension so that other uses can potentially do the same?
There was a problem hiding this comment.
sure, will refactor that
…ndency visualization
nkcsgexi
force-pushed
the
prebuilt-dump-dependencies
branch
from
1009e66 to
7da6a5e
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.