Skip to content

Setup single dependency mode #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

cltnschlosser
Copy link
Contributor

Adapted from: swiftlang/swift@2a79331

Fixes validation-test/Driver/batch_mode_size_limit.swift

@cltnschlosser cltnschlosser force-pushed the cs_OnlyOneDependencyFile branch from 6e2fc7a to 38b8883 Compare May 13, 2020 03:57
@DougGregor
Copy link
Member

Uh oh. We were thinking of removing this feature entirely from the old Swift driver, and instead having the build systems only ask for a single dependency file.

@cltnschlosser
Copy link
Contributor Author

Uh oh. We were thinking of removing this feature entirely from the old Swift driver, and instead having the build systems only ask for a single dependency file.

Haha, maybe we just let this one sit then. Or close now if we are sure this feature is going to be removed. I’ve just been going through the lit test failures and picking files that sound interesting.

@DougGregor
Copy link
Member

I'm fine with letting it sit until we're sure, thanks

@cltnschlosser
Copy link
Contributor Author

Should I pull out the driver show lifecycle stuff into a separate PR?

@DougGregor
Copy link
Member

Should I pull out the driver show lifecycle stuff into a separate PR?

Yes, please!

@shahmishal shahmishal closed this Oct 5, 2020
@shahmishal
Copy link
Member

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create pull request with main branch.

More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants