Support VirtualPaths in ToolChain #77
Conversation
There was a problem hiding this comment.
Looks good!
Btw, I think it looks more and more obvious that VirtualPath is not a silver bullet for all path operations. Most of operations with them are correct only for absolute or relative path, I wonder if it can be made more robust, but introducing another layer like VirtualPath.filesystemPath(.absolute(foobar)) is also not looking good. It is probably worth looking at use cases of stdin/out and temporary to see if there is some good way.
Also, it's a bit unfortunate that TCSBasic doesn't have ways to do operations with relative paths without resolving it to absolute path beforehand :(
…than absolute or relative paths
Going to take a look at stdin, stdout, and temporary usages. Maybe we introduce another type for the ToolChain that only has Absolute and Relative paths. |
| case .standardInput, .standardOutput: | ||
| preconditionFailure("standardInput and standardOutput do not have a pathString") | ||
| case .temporary(let path): | ||
| return path.pathString |
There was a problem hiding this comment.
This probably isn't correct. Given that this relative path doesn't contain the temporary directory.
|
The Swift project moved the default branch to More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412 |
Fixes:
Swift(macosx-x86_64) :: Driver/driver-use-frontend.swift
Swift(macosx-x86_64) :: Driver/linker-rpath.swift
This should go in after #73 since it copies some extensions from there.