Skip to content

Commit b2c3fc5

Browse files
authored
Merge pull request #1253 from beccadax/my-name-is-neo
Correct contributor’s name
2 parents 5f79481 + bdfc22a commit b2c3fc5

20 files changed

+27
-27
lines changed

proposals/0047-nonvoid-warn.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,5 +145,5 @@ Upon acceptance, this proposal removes two of the last remaining instances of sn
145145

146146
## Acknowledgements
147147

148-
Changing the behavior of non-void functions to use default warnings for unused results was initially introduced by Adrian Kashivskyy. Additional thanks go out to Chris Lattner, Gwendal Roué, Dmitri Gribenko, Jeff Kelley, David Owens, Jed Lewison, Stephen Cellis, Ankit Aggarwal, Paul Ossenbruggen,Brent Royal-Gordon, Tino Heth, Haravikk, Félix Cloutier,Yuta Koshizawa,
148+
Changing the behavior of non-void functions to use default warnings for unused results was initially introduced by Adrian Kashivskyy. Additional thanks go out to Chris Lattner, Gwendal Roué, Dmitri Gribenko, Jeff Kelley, David Owens, Jed Lewison, Stephen Cellis, Ankit Aggarwal, Paul Ossenbruggen, Becca Royal-Gordon, Tino Heth, Haravikk, Félix Cloutier,Yuta Koshizawa,
149149
for their feedback on this topic.

proposals/0056-trailing-closures-in-guard.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ There are four primary alternatives:
9090
in the Swift 2 timeframe. I feel that it has stood the test of time well
9191
since then.
9292

93-
* *Change the syntax of `if` and `while`*: Brent Royal-Gordon points out that
93+
* *Change the syntax of `if` and `while`*: Becca Royal-Gordon points out that
9494
we could change `if` and `while` to use a keyword after their condition as
9595
well, e.g.:
9696

proposals/0068-universal-self.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Not at this time
5757

5858
## Acknowledgements
5959

60-
Thanks Sean Heber, Lily Ballard, Joe Groff, Timothy Wood, Brent Royal-Gordon, Andrey Tarantsov, Austin Zheng
60+
Thanks Sean Heber, Lily Ballard, Joe Groff, Timothy Wood, Becca Royal-Gordon, Andrey Tarantsov, Austin Zheng
6161

6262
## Rationale
6363

proposals/0084-trailing-commas.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ Allowing cut and paste or commenting of entire parameter lines means simple chan
7979

8080
> "Having used, more or less continuously for my 20 years as a professional programmer, both a language that allows trailing commas and one that does not, I come down pretty strongly on the side of allowing trailing commas (for all the reasons already stated in this thread). If it means requiring a newline after the last comma to make some people feel better about it, so be it." - John Siracusa
8181
82-
> "I was skeptical of this until a week or two ago, when I had some code where I ended up commenting out certain parameters. Removing the now-trailing commas was an inconvenience. So, +1 from me." - Brent Royal-Gordon
82+
> "I was skeptical of this until a week or two ago, when I had some code where I ended up commenting out certain parameters. Removing the now-trailing commas was an inconvenience. So, +1 from me." - Becca Royal-Gordon
8383
8484
> "We should be consistent in either accepting or rejecting trailing commas everywhere we have comma-delimited syntax. I'm in favor of accepting it, since it's popular in languages where it's supported to enable a minimal-diff style, so that changes to code don't impact neighboring lines for purely syntactic reasons.
8585
>

proposals/0089-rename-string-reflection-init.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Renaming `String.init<T>(_: T)`
22

33
* Proposal: [SE-0089](0089-rename-string-reflection-init.md)
4-
* Authors: [Austin Zheng](https://github.com/austinzheng), [Brent Royal-Gordon](https://github.com/brentdax)
4+
* Authors: [Austin Zheng](https://github.com/austinzheng), [Becca Royal-Gordon](https://github.com/beccadax)
55
* Review Manager: [Chris Lattner](http://github.com/lattner)
66
* Status: **Implemented (Swift 3)**
77
* Decision Notes: [Rationale](https://lists.swift.org/pipermail/swift-evolution-announce/2016-June/000190.html)

proposals/0095-any-as-existential.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,5 +72,5 @@ The original proposal suggested replacing `protocol<>` with either `Any<>` or `a
7272

7373
## Acknowledgements
7474

75-
[Matthew Johnson](https://github.com/anandabits) and [Brent Royal-Gordon](https://github.com/brentdax) provided valuable input which helped shape the first version of this proposal.
75+
[Matthew Johnson](https://github.com/anandabits) and [Becca Royal-Gordon](https://github.com/beccadax) provided valuable input which helped shape the first version of this proposal.
7676

proposals/0105-remove-where-from-forin-loops.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,4 +153,4 @@ Code must be refactored to move the where clause into `guard` (or, for less styl
153153

154154
## Acknowledgements
155155

156-
Big thanks to Joe Groff, Brent Royal-Gordon, Xiaodi Wu
156+
Big thanks to Joe Groff, Becca Royal-Gordon, Xiaodi Wu

proposals/0132-sequence-end-ops.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Rationalizing Sequence end-operation names
22

33
* Proposal: [SE-0132](0132-sequence-end-ops.md)
4-
* Authors: [Brent Royal-Gordon](https://github.com/brentdax), [Dave Abrahams](https://github.com/dabrahams)
4+
* Authors: [Becca Royal-Gordon](https://github.com/beccadax), [Dave Abrahams](https://github.com/dabrahams)
55
* Review Manager: [Chris Lattner](http://github.com/lattner)
66
* Status: **Rejected**
77
* Decision Notes: [Rationale](https://lists.swift.org/pipermail/swift-evolution-announce/2016-July/000267.html)

proposals/0148-generic-subscripts.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ Adding default arguments would unify the compiler's handling of subscripts and f
6464

6565
## Source compatibility
6666

67-
This is a purely additive change. We don't propose changing the Standard Library to use this new feature, that should be part of a separate proposal. (Likewise, we should consider making subscripts `throws` in a [separate proposal](https://github.com/brentdax/swift-evolution/blob/throwing-properties/proposals/0000-throwing-properties.md)).
67+
This is a purely additive change. We don't propose changing the Standard Library to use this new feature, that should be part of a separate proposal. (Likewise, we should consider making subscripts `throws` in a [separate proposal](https://github.com/beccadax/swift-evolution/blob/throwing-properties/proposals/0000-throwing-properties.md)).
6868

6969
## Effect on ABI stability
7070

proposals/0168-multi-line-string-literals.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Multi-Line String Literals
22

33
* Proposal: [SE-0168](0168-multi-line-string-literals.md)
4-
* Authors: [John Holdsworth](https://github.com/johnno1962), [Brent Royal-Gordon](https://github.com/brentdax), [Tyler Cloutier](https://github.com/TheArtOfEngineering)
4+
* Authors: [John Holdsworth](https://github.com/johnno1962), [Becca Royal-Gordon](https://github.com/beccadax), [Tyler Cloutier](https://github.com/TheArtOfEngineering)
55
* Review Manager: [Joe Groff](https://github.com/jckarter)
66
* Status: **Implemented (Swift 4)**
77
* Implementation: [apple/swift#8813](https://github.com/apple/swift/pull/8813)

proposals/0172-one-sided-ranges.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# One-sided Ranges
22

33
* Proposal: [SE-0172](0172-one-sided-ranges.md)
4-
* Authors: [Ben Cohen](https://github.com/airspeedswift), [Dave Abrahams](https://github.com/dabrahams), [Brent Royal-Gordon](https://github.com/brentdax)
4+
* Authors: [Ben Cohen](https://github.com/airspeedswift), [Dave Abrahams](https://github.com/dabrahams), [Becca Royal-Gordon](https://github.com/beccadax)
55
* Review Manager: [Doug Gregor](https://github.com/DougGregor)
66
* Status: **Implemented (Swift 4)**
77
* Decision Notes: [Rationale](https://lists.swift.org/pipermail/swift-evolution/Week-of-Mon-20170424/036125.html)

proposals/0192-non-exhaustive-enums.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,7 @@ I didn't have a strong preference for any particular choice as long as it *isn't
468468

469469
Note that "nonextensible" does have one problem: Apple already uses [`NS_TYPED_EXTENSIBLE_ENUM `][NS_TYPED_EXTENSIBLE_ENUM] to refer to enum-like sets of constants (usually strings) that *clients* can add "cases" to. That's not the same meaning as the exhaustiveness discussed in this proposal.
470470

471-
During the first review for this proposal, Brent Royal-Gordon suggested "frozen", which was met with general approval or at least no major objections.
471+
During the first review for this proposal, Becca Royal-Gordon suggested "frozen", which was met with general approval or at least no major objections.
472472

473473
[NS_TYPED_EXTENSIBLE_ENUM]: https://developer.apple.com/library/content/documentation/Swift/Conceptual/BuildingCocoaApps/InteractingWithCAPIs.html#//apple_ref/doc/uid/TP40014216-CH8-ID206
474474

@@ -538,7 +538,7 @@ unknown:
538538

539539
### Testing invalid cases
540540

541-
Another issue with non-frozen enums is that clients cannot properly test what happens when a new case is introduced, almost by definition. Brent Royal-Gordon came up with the idea to have a new type annotation that would allow the creation of an invalid enum value. Since this is only something to use for testing, the initial version of the idea used `@testable` as the spelling for the annotation. The tests could then use a special expression, `#invalid`, to pass this invalid value to a function with a `@testable` enum parameter.
541+
Another issue with non-frozen enums is that clients cannot properly test what happens when a new case is introduced, almost by definition. Becca Royal-Gordon came up with the idea to have a new type annotation that would allow the creation of an invalid enum value. Since this is only something to use for testing, the initial version of the idea used `@testable` as the spelling for the annotation. The tests could then use a special expression, `#invalid`, to pass this invalid value to a function with a `@testable` enum parameter.
542542

543543
However, this would only work in cases where the action to be taken does not actually depend on the enum value. If it needs to be passed to the original library that owns the enum, or used with an API that is not does not have this annotation, the code still cannot be tested properly.
544544

proposals/0194-derived-collection-of-enum-cases.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Derived Collection of Enum Cases
22

33
* Proposal: [SE-0194](0194-derived-collection-of-enum-cases.md)
4-
* Authors: [Jacob Bandes-Storch](https://github.com/jtbandes), [Brent Royal-Gordon](https://github.com/brentdax), [Robert Widmann](https://github.com/CodaFi)
4+
* Authors: [Jacob Bandes-Storch](https://github.com/jtbandes), [Becca Royal-Gordon](https://github.com/beccadax), [Robert Widmann](https://github.com/CodaFi)
55
* Review Manager: [Doug Gregor](https://github.com/DougGregor)
66
* Review Thread: [SE-0194 review][se8]
77
* Status: **Implemented (Swift 4.2)**

proposals/0200-raw-string-escaping.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Enhancing String Literals Delimiters to Support Raw Text
22

33
* Proposal: [SE-0200](0200-raw-string-escaping.md)
4-
* Authors: [John Holdsworth](https://github.com/johnno1962), [Brent Royal-Gordon](https://github.com/brentdax), [Erica Sadun](https://github.com/erica)
4+
* Authors: [John Holdsworth](https://github.com/johnno1962), [Becca Royal-Gordon](https://github.com/beccadax), [Erica Sadun](https://github.com/erica)
55
* Review Manager: [Doug Gregor](https://github.com/DougGregor)
66
* Previous Revision: [1](https://github.com/apple/swift-evolution/blob/102b2f2770f0dab29f254a254063847388647a4a/proposals/0200-raw-string-escaping.md)
77
* Status: **Implemented (Swift 5)**

proposals/0225-binaryinteger-iseven-isodd-ismultiple.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ For some user-defined types, especially bignum types, you may want to implement
178178
* [Precondition check in sqlite function](https://github.com/sqlcipher/sqlcipher/blob/c6f709fca81c910ba133aaf6330c28e01ccfe5f8/src/crypto_impl.c#L1296)
179179
* [Alternating UITableView cell background style](https://github.com/alloy/HockeySDK-CocoaPods/blob/978f3f072d206cfa35f4789d3a5b3abb31b9df11/Pods/HockeySDK/Classes/BITFeedbackListViewController.m#L502). NSTableView [has built in support](https://developer.apple.com/documentation/appkit/nstableview/1533967-usesalternatingrowbackgroundcolo?language=objc) for this.
180180
* [Barcode reading](https://github.com/TheLevelUp/ZXingObjC/blob/d952cc02beb948ab49832661528c5e3e4953885e/ZXingObjC/oned/rss/expanded/ZXRSSExpandedReader.m#L449)
181-
* [CSS row and column styling](https://www.w3.org/Style/Examples/007/evenodd.en.html) with `nth-child(even)` and `nth-child(odd)` (h/t @brentdax)
181+
* [CSS row and column styling](https://www.w3.org/Style/Examples/007/evenodd.en.html) with `nth-child(even)` and `nth-child(odd)` (h/t @beccadax)
182182
* Various test code
183183

184184
Some _really_ real-world examples:

proposals/0228-fix-expressiblebystringinterpolation.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Fix `ExpressibleByStringInterpolation`
22

33
* Proposal: [SE-0228](0228-fix-expressiblebystringinterpolation.md)
4-
* Authors: [Brent Royal-Gordon](https://github.com/brentdax), [Michael Ilseman](https://github.com/milseman)
4+
* Authors: [Becca Royal-Gordon](https://github.com/beccadax), [Michael Ilseman](https://github.com/milseman)
55
* Review Manager: [Doug Gregor](https://github.com/DougGregor)
66
* Status: **Implemented (Swift 5)**
77
* Review: [Discussion thread](https://forums.swift.org/t/se-0228-fix-expressible-by-string-interpolation/16031), [Announcement thread](https://forums.swift.org/t/accepted-se-0228-fix-expressible-by-string-interpolation/16548)
@@ -33,9 +33,9 @@ We see three general classes of types that might want to conform to `Expressible
3333

3434
The current design handles simple textual data, but struggles to support structured textual data and machine-readable code fragments.
3535

36-
[sql]: https://github.com/brentdax/SQLKit/blob/master/Sources/SQLKit/SQLStatement.swift
36+
[sql]: https://github.com/beccadax/SQLKit/blob/master/Sources/SQLKit/SQLStatement.swift
3737
[html]: https://oleb.net/blog/2017/01/fun-with-string-interpolation/
38-
[loc]: https://gist.github.com/brentdax/79fa038c0af0cafb52dd
38+
[loc]: https://gist.github.com/beccadax/79fa038c0af0cafb52dd
3939

4040
### Current design
4141

@@ -188,7 +188,7 @@ String(stringInterpolation: {
188188

189189
[We have written a few examples of conforming types.][examples]
190190

191-
[examples]: https://gist.github.com/brentdax/0b46ce25b7da1049e61b4669352094b6
191+
[examples]: https://gist.github.com/beccadax/0b46ce25b7da1049e61b4669352094b6
192192

193193
## Detailed design
194194

proposals/0254-static-subscripts.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Static and class subscripts
22

33
* Proposal: [SE-0254](0254-static-subscripts.md)
4-
* Author: [Brent Royal-Gordon](https://github.com/brentdax)
4+
* Author: [Becca Royal-Gordon](https://github.com/beccadax)
55
* Review Manager: [Doug Gregor](https://github.com/DougGregor)
66
* Status: **Implemented (Swift 5.1)**
77
* Implementation: [apple/swift#23358](https://github.com/apple/swift/pull/23358)

proposals/0258-property-wrappers.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ enum GlobalSettings {
589589

590590
### Copy-on-write
591591

592-
With some work, property wrappers can provide copy-on-write wrappers (original example courtesy of Brent Royal-Gordon):
592+
With some work, property wrappers can provide copy-on-write wrappers (original example courtesy of Becca Royal-Gordon):
593593

594594
```swift
595595
protocol Copyable: AnyObject {
@@ -1569,4 +1569,4 @@ One could express this either by naming the property directly (as above) or, for
15691569

15701570
## Acknowledgments
15711571

1572-
This proposal was greatly improved throughout its [first pitch](https://forums.swift.org/t/pitch-property-delegates/21895) by many people. Harlan Haskins, Brent Royal-Gordon, Adrian Zubarev, Jordan Rose and others provided great examples of uses of property wrappers (several of which are in this proposal). Adrian Zubarev and Kenny Leung helped push on some of the core assumptions and restrictions of the original proposal, helping to make it more general. Vini Vendramini and David Hart helped tie this proposal together with custom attributes, which drastically reduced the syntactic surface area of this proposal.
1572+
This proposal was greatly improved throughout its [first pitch](https://forums.swift.org/t/pitch-property-delegates/21895) by many people. Harlan Haskins, Becca Royal-Gordon, Adrian Zubarev, Jordan Rose and others provided great examples of uses of property wrappers (several of which are in this proposal). Adrian Zubarev and Kenny Leung helped push on some of the core assumptions and restrictions of the original proposal, helping to make it more general. Vini Vendramini and David Hart helped tie this proposal together with custom attributes, which drastically reduced the syntactic surface area of this proposal.

proposals/0274-magic-file.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Concise magic file names
22

33
* Proposal: [SE-0274](0274-magic-file.md)
4-
* Authors: [Brent Royal-Gordon](https://github.com/brentdax), [Dave DeLong](https://github.com/davedelong)
4+
* Authors: [Becca Royal-Gordon](https://github.com/beccadax), [Dave DeLong](https://github.com/davedelong)
55
* Review Manager: [Ben Cohen](https://github.com/airspeedswift/)
66
* Original review: [Returned for revision](https://forums.swift.org/t/se-0274-concise-magic-file-names/32373/50)
77
* Status: **Accepted**
@@ -49,7 +49,7 @@ For `#file`'s most important use case, it seems like the current string computed
4949

5050
We propose changing the string that `#file` evaluates to—instead of evaluating to the full path, it will now have the format `<module-name>/<file-name>`. For those applications which still need a full path, we will provide a new magic identifier, `#filePath`. Both of these features will otherwise behave the same as the old `#file`, including capturing the call site location when used in default arguments. The standard library's assertion and error functions will continue to use `#file`.
5151

52-
With this proposal, a file at `/Users/brent/Desktop/0274-magic-file.swift` in a module named `MagicFile` with this content:
52+
With this proposal, a file at `/Users/becca/Desktop/0274-magic-file.swift` in a module named `MagicFile` with this content:
5353

5454
```swift
5555
print(#file)
@@ -61,7 +61,7 @@ Would produce this output:
6161

6262
```text
6363
MagicFile/0274-magic-file.swift
64-
/Users/brent/Desktop/0274-magic-file.swift
64+
/Users/becca/Desktop/0274-magic-file.swift
6565
Fatal error: Something bad happened!: file MagicFile/0274-magic-file.swift, line 3
6666
```
6767

proposals/0285-ease-pound-file-transition.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Ease the transition to concise magic file strings
22

33
* Proposal: [SE-0285](0285-ease-pound-file-transition.md)
4-
* Author: [Brent Royal-Gordon](https://github.com/brentdax)
4+
* Author: [Becca Royal-Gordon](https://github.com/beccadax)
55
* Review Manager: [Tom Doron](https://github.com/tomerd)
66
* Implementation: [apple/swift#32700](https://github.com/apple/swift/pull/32700)
77
* Status: **Implemented (Swift 5.3)**

0 commit comments

Comments
 (0)