Throw error if we encounter stray opening '('

This should be unreachable, let's make sure of
that. Doing so requires generalizing the handling
of LocatedError a bit.

Author: hamishknight

Sources/_RegexParser/Regex/Parse/LexicalAnalysis.swift

@@ -21,6 +21,16 @@ API convention:
 - eat() and tryEat() is still used by the parser as a character-by-character interface
 */
 
+extension Error {
+  func addingLocation(_ loc: Range<Source.Position>) -> Error {
+    // If we're already a LocatedError, don't change the location.
+    if self is _LocatedErrorProtocol {
+      return self
+    }
+    return Source.LocatedError<Self>(self, loc)
+  }
+}
+
 extension Source {
   // MARK: - recordLoc
 
@@ -51,12 +61,8 @@ extension Source {
     do {
       guard let result = try f(&self) else { return nil }
       return Located(result, start..<currentPosition)
-    } catch let e as Source.LocatedError<ParseError> {
-      throw e
-    } catch let e as ParseError {
-      throw LocatedError(e, start..<currentPosition)
-    } catch {
-      fatalError("FIXME: Let's not keep the boxed existential...")
+    } catch let e {
+      throw e.addingLocation(start..<currentPosition)
     }
   }
 
@@ -1844,6 +1850,9 @@ extension Source {
         }
         throw Unreachable("TODO: reason")
 
+      case "(" where !customCC:
+        throw Unreachable("Should have lexed a group or group-like atom")
+
       // (sometimes) special metacharacters
       case ".": return customCC ? .char(".") : .any
       case "^": return customCC ? .char("^") : .startOfLine

Sources/_RegexParser/Regex/Parse/SourceLocation.swift

@@ -56,9 +56,11 @@ extension Source {
   var currentPosition: Position { bounds.lowerBound }
 }
 
+protocol _LocatedErrorProtocol: Error {}
+
 extension Source {
   /// An error with source location info
-  public struct LocatedError<E: Error>: Error {
+  public struct LocatedError<E: Error>: Error, _LocatedErrorProtocol {
     public let error: E
     public let location: SourceLocation
 
@@ -70,7 +72,6 @@ extension Source {
       self.error = v
       self.location = Location(r)
     }
-
   }
 
   /// Located value: a value wrapped with a source range