Delete unsafe UseEnumsForNamespacing rule

While using enums for namespaces is a superior coding practice, this rule lacks sufficient context to safely perform this transformation. It's possible to use extensions in the same file or a different file to add a conformance to a struct which makes it ineligible to become an enum. Unfortunately, the SyntaxVisitor is only able to look at nodes in the AST for a single file and that is too narrow of a scope to verify that the struct can safely be an enum.

Even as a lint rule, this would raise false positives and those false positives cannot be removed. It's best not to convert to a lint rule for that reason.

Author: dylansturg

Sources/SwiftFormat/Pipelines+Generated.swift

@@ -225,7 +225,6 @@ class LintPipeline: SyntaxVisitor {
     visitIfEnabled(BeginDocumentationCommentWithOneLineSummary.visit, in: context, for: node)
     visitIfEnabled(DontRepeatTypeInStaticProperties.visit, in: context, for: node)
     visitIfEnabled(NoLeadingUnderscores.visit, in: context, for: node)
-    visitIfEnabled(UseEnumForNamespacing.visit, in: context, for: node)
     visitIfEnabled(UseSynthesizedInitializer.visit, in: context, for: node)
     visitIfEnabled(UseTripleSlashForDocumentationComments.visit, in: context, for: node)
     return .visitChildren
@@ -300,7 +299,6 @@ extension FormatPipeline {
     node = OneVariableDeclarationPerLine(context: context).visit(node)
     node = OrderedImports(context: context).visit(node)
     node = ReturnVoidInsteadOfEmptyTuple(context: context).visit(node)
-    node = UseEnumForNamespacing(context: context).visit(node)
     node = UseShorthandTypeNames(context: context).visit(node)
     node = UseSingleLinePropertyGetter(context: context).visit(node)
     node = UseTripleSlashForDocumentationComments(context: context).visit(node)

Sources/SwiftFormatConfiguration/RuleRegistry+Generated.swift

@@ -40,7 +40,6 @@ enum RuleRegistry {
     "OnlyOneTrailingClosureArgument": true,
     "OrderedImports": true,
     "ReturnVoidInsteadOfEmptyTuple": true,
-    "UseEnumForNamespacing": true,
     "UseLetInEveryBoundCaseVariable": true,
     "UseShorthandTypeNames": true,
     "UseSingleLinePropertyGetter": true,

Sources/SwiftFormatRules/UseEnumForNamespacing.swift

@@ -299,16 +299,6 @@ extension UseEarlyExitsTests {
     ]
 }
 
-extension UseEnumForNamespacingTests {
-    // DO NOT MODIFY: This is autogenerated, use:
-    //   `swift test --generate-linuxmain`
-    // to regenerate.
-    static let __allTests__UseEnumForNamespacingTests = [
-        ("testNestedEnumsForNameSpaces", testNestedEnumsForNameSpaces),
-        ("testNonEnumsUsedAsNamespaces", testNonEnumsUsedAsNamespaces),
-    ]
-}
-
 extension UseLetInEveryBoundCaseVariableTests {
     // DO NOT MODIFY: This is autogenerated, use:
     //   `swift test --generate-linuxmain`
@@ -428,7 +418,6 @@ public func __allTests() -> [XCTestCaseEntry] {
         testCase(OrderedImportsTests.__allTests__OrderedImportsTests),
         testCase(ReturnVoidInsteadOfEmptyTupleTests.__allTests__ReturnVoidInsteadOfEmptyTupleTests),
         testCase(UseEarlyExitsTests.__allTests__UseEarlyExitsTests),
-        testCase(UseEnumForNamespacingTests.__allTests__UseEnumForNamespacingTests),
         testCase(UseLetInEveryBoundCaseVariableTests.__allTests__UseLetInEveryBoundCaseVariableTests),
         testCase(UseShorthandTypeNamesTests.__allTests__UseShorthandTypeNamesTests),
         testCase(UseSingleLinePropertyGetterTests.__allTests__UseSingleLinePropertyGetterTests),