Skip to content

Delete unsafe UseEnumsForNamespacing rule #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Delete unsafe UseEnumsForNamespacing rule #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Sources/SwiftFormat/Pipelines+Generated.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ class LintPipeline: SyntaxVisitor {
visitIfEnabled(BeginDocumentationCommentWithOneLineSummary.visit, in: context, for: node)
visitIfEnabled(DontRepeatTypeInStaticProperties.visit, in: context, for: node)
visitIfEnabled(NoLeadingUnderscores.visit, in: context, for: node)
visitIfEnabled(UseEnumForNamespacing.visit, in: context, for: node)
visitIfEnabled(UseSynthesizedInitializer.visit, in: context, for: node)
visitIfEnabled(UseTripleSlashForDocumentationComments.visit, in: context, for: node)
return .visitChildren
Expand Down Expand Up @@ -300,7 +299,6 @@ extension FormatPipeline {
node = OneVariableDeclarationPerLine(context: context).visit(node)
node = OrderedImports(context: context).visit(node)
node = ReturnVoidInsteadOfEmptyTuple(context: context).visit(node)
node = UseEnumForNamespacing(context: context).visit(node)
node = UseShorthandTypeNames(context: context).visit(node)
node = UseSingleLinePropertyGetter(context: context).visit(node)
node = UseTripleSlashForDocumentationComments(context: context).visit(node)
Expand Down
1 change: 0 additions & 1 deletion Sources/SwiftFormatConfiguration/RuleRegistry+Generated.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ enum RuleRegistry {
"OnlyOneTrailingClosureArgument": true,
"OrderedImports": true,
"ReturnVoidInsteadOfEmptyTuple": true,
"UseEnumForNamespacing": true,
"UseLetInEveryBoundCaseVariable": true,
"UseShorthandTypeNames": true,
"UseSingleLinePropertyGetter": true,
Expand Down
114 changes: 0 additions & 114 deletions Sources/SwiftFormatRules/UseEnumForNamespacing.swift
View file
Open in desktop

This file was deleted.

224 changes: 0 additions & 224 deletions Tests/SwiftFormatRulesTests/UseEnumForNamespacingTests.swift
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions Tests/SwiftFormatRulesTests/XCTestManifests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,16 +299,6 @@ extension UseEarlyExitsTests {
]
}

extension UseEnumForNamespacingTests {
// DO NOT MODIFY: This is autogenerated, use:
// `swift test --generate-linuxmain`
// to regenerate.
static let __allTests__UseEnumForNamespacingTests = [
("testNestedEnumsForNameSpaces", testNestedEnumsForNameSpaces),
("testNonEnumsUsedAsNamespaces", testNonEnumsUsedAsNamespaces),
]
}

extension UseLetInEveryBoundCaseVariableTests {
// DO NOT MODIFY: This is autogenerated, use:
// `swift test --generate-linuxmain`
Expand Down Expand Up @@ -428,7 +418,6 @@ public func __allTests() -> [XCTestCaseEntry] {
testCase(OrderedImportsTests.__allTests__OrderedImportsTests),
testCase(ReturnVoidInsteadOfEmptyTupleTests.__allTests__ReturnVoidInsteadOfEmptyTupleTests),
testCase(UseEarlyExitsTests.__allTests__UseEarlyExitsTests),
testCase(UseEnumForNamespacingTests.__allTests__UseEnumForNamespacingTests),
testCase(UseLetInEveryBoundCaseVariableTests.__allTests__UseLetInEveryBoundCaseVariableTests),
testCase(UseShorthandTypeNamesTests.__allTests__UseShorthandTypeNamesTests),
testCase(UseSingleLinePropertyGetterTests.__allTests__UseSingleLinePropertyGetterTests),
Expand Down