Use a Set to track visited exprs.
#198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
approved these changes
Jun 8, 2020
aaditya-chandrasekhar
pushed a commit
to val-verde/swift-format
that referenced
this pull request
May 20, 2021
Verifies that generated `all.css` contains the `:root` string on CI. It doesn't do any actual CSS parsing to verify its full validity, only does a simple `grep` check, but I hope this will be enough to prevent issues like swiftlang#198 in the future. * Test that `all.css` contains a valid CSS selector * Update `CHANGELOG.md` * Install graphviz to avoid warnings on macOS * Add EndToEndTests subclassing XCTest * Apply suggestions from code review Co-authored-by: Mattt <[email protected]> * Remove stray comment leftover from review * Set macOS 10.13 as minimum platform target * Refactor EndToEndTests Create helper methods on Process and Bundle * Test whether generated HTML output contains subdirectories * Add test for CommonMark output * Add tests for coverage subcommand * Add tests for diagram subcommand * Update Changelog entry for swiftlang#199 * Work around unavailability of hasDirectoryPath * Update Changelog.md Co-authored-by: Max Desiatov <[email protected]> * Update Changelog entry for swiftlang#199 Co-authored-by: Mattt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of contextual breaks, some expressions are visited ahead of their visit method by traversing nested expressions and inserting contextual breaks. Already visited expressions were tracked using an array. Since this was purely for looking up which expressions were already visited, a set is much faster for lookup.
This has a significant performance impact for files that contain many expressions, but minimal impact for files with few exprs (essentially large files vs small files). I tested formatting all of swift-protobuf and a single large (10k LOC) file. The times are an average from running 4 times.