UseSingleLinePropertyGetter: respect async and throws on getters
#279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
approved these changes
Feb 9, 2022
cbjeukendrup
deleted the
UseSingleLinePropertyGetter_not_with_async_throws
branch
mironal
added a commit
to mironal/TwitterAPIKit
that referenced
this pull request
Feb 18, 2022
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Mar 18, 2022
…rtyGetter_not_with_async_throws UseSingleLinePropertyGetter: respect `async` and `throws` on getters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: SR-15671
With this patch, the
UseSingleLinePropertyGetterrule will takeasyncandthrowson getters into account. When one of those is present, the rule won't be applied; otherwise, the semantics would be changed, by removingasyncand/orthrows.The tests are extended accordingly.