Remove macro special cases #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these specialty nodes will be subsumed by MacroExpansionExprSyntax or MacroExpansionDeclSyntax.
|
@swift-ci please test |
|
@allevato I hope it's alright that I merged this, but please ping if you'd like me to follow a different process. It passed PR testing via swiftlang/swift-syntax#1132 and I believe the formatting change was an improvement, because |
|
@DougGregor It's all good! Please feel free to merge swift-format changes that unblock swift-syntax work. I agree that that looks like the right formatting change to make the "new" macro consistent with other similar syntax. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove special-case logic for a number of expressions that will be subsumed by
MacroExpansionExprSyntaxandMacroExpansionDeclSyntax:#selector,#keyPath,#file,#line,#column,#function,#warning,#error,#dsohandle.The one formatting change corresponds to the swift-syntax change in swiftlang/swift-syntax#1132 to use
MacroExpansionExprSyntaxfor#selector. That PR also removes the syntax nodes we stop using here.