Use nonblocking IO for open (#1228)

parkera · web-flow · commit 05975959e67f · 2025-03-27T12:57:48.000-07:00
Windows is blocked by a CI/infra issue. This doesn't affect that code, so merging.
diff --git a/Sources/FoundationEssentials/Data/Data+Reading.swift b/Sources/FoundationEssentials/Data/Data+Reading.swift
@@ -301,7 +301,8 @@ internal func readBytesFromFile(path inPath: PathOrURL, reportProgress: Bool, ma
         guard let inPathFileSystemRep else {
             throw CocoaError(.fileReadInvalidFileName)
         }
-        return open(inPathFileSystemRep, O_RDONLY, 0o666)
+        // Do not block on opening the file here. If the file is not a regular one, we will produce an error below after `fstat`.
+        return open(inPathFileSystemRep, O_RDONLY | O_NONBLOCK, 0o666)
     }
         
     guard fd >= 0 else {

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,8 @@ internal func readBytesFromFile(path inPath: PathOrURL, reportProgress: Bool, ma`
`301`	`301`	`guard let inPathFileSystemRep else {`
`302`	`302`	`throw CocoaError(.fileReadInvalidFileName)`
`303`	`303`	`}`
`304`		`- return open(inPathFileSystemRep, O_RDONLY, 0o666)`
	`304`	+ // Do not block on opening the file here. If the file is not a regular one, we will produce an error below after `fstat`.
	`305`	`+ return open(inPathFileSystemRep, O_RDONLY \| O_NONBLOCK, 0o666)`
`305`	`306`	`}`
`306`	`307`
`307`	`308`	`guard fd >= 0 else {`