Make trivial AttributedString dynamicMemberLookup subscripts inlinable (#1207)

jmschonfeld · web-flow · commit 4c021b6e57bc · 2025-03-12T12:43:14.000-07:00
diff --git a/Sources/FoundationEssentials/AttributedString/AttributeContainer.swift b/Sources/FoundationEssentials/AttributedString/AttributeContainer.swift
@@ -33,6 +33,7 @@ extension AttributeContainer {
     }
 
     @preconcurrency
+    @inlinable // Trivial implementation, allows callers to optimize away the keypath allocation
     public subscript<K: AttributedStringKey>(dynamicMember keyPath: KeyPath<AttributeDynamicLookup, K>) -> K.Value? where K.Value : Sendable {
         get { self[K.self] }
         set { self[K.self] = newValue }
diff --git a/Sources/FoundationEssentials/AttributedString/AttributedString+Runs+Run.swift b/Sources/FoundationEssentials/AttributedString/AttributedString+Runs+Run.swift
@@ -81,6 +81,7 @@ extension AttributedString.Runs.Run {
 @available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
 extension AttributedString.Runs.Run {
     @preconcurrency
+    @inlinable // Trivial implementation, allows callers to optimize away the keypath allocation
     public subscript<K: AttributedStringKey>(
         dynamicMember keyPath: KeyPath<AttributeDynamicLookup, K>
     ) -> K.Value?
diff --git a/Sources/FoundationEssentials/AttributedString/AttributedString.swift b/Sources/FoundationEssentials/AttributedString/AttributedString.swift
@@ -243,6 +243,7 @@ extension AttributedString: AttributedStringProtocol {
     }
     
     @preconcurrency
+    @inlinable // Trivial implementation, allows callers to optimize away the keypath allocation
     public subscript<K: AttributedStringKey>(
         dynamicMember keyPath: KeyPath<AttributeDynamicLookup, K>
     ) -> K.Value? where K.Value: Sendable {
diff --git a/Sources/FoundationEssentials/AttributedString/AttributedSubstring.swift b/Sources/FoundationEssentials/AttributedString/AttributedSubstring.swift
@@ -177,6 +177,7 @@ extension AttributedSubstring {
     }
 
     @preconcurrency
+    @inlinable // Trivial implementation, allows callers to optimize away the keypath allocation
     public subscript<K: AttributedStringKey>(
         dynamicMember keyPath: KeyPath<AttributeDynamicLookup, K>
     ) -> K.Value? where K.Value : Sendable {
diff --git a/Sources/FoundationEssentials/AttributedString/DiscontiguousAttributedSubstring.swift b/Sources/FoundationEssentials/AttributedString/DiscontiguousAttributedSubstring.swift
@@ -194,6 +194,7 @@ extension DiscontiguousAttributedSubstring {
         }
     }
     
+    @inlinable // Trivial implementation, allows callers to optimize away the keypath allocation
     public subscript<K: AttributedStringKey>(
         dynamicMember keyPath: KeyPath<AttributeDynamicLookup, K>
     ) -> K.Value? where K.Value : Sendable {

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ extension AttributeContainer {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`@preconcurrency`
	`36`	`+ @inlinable // Trivial implementation, allows callers to optimize away the keypath allocation`
`36`	`37`	`public subscript<K: AttributedStringKey>(dynamicMember keyPath: KeyPath<AttributeDynamicLookup, K>) -> K.Value? where K.Value : Sendable {`
`37`	`38`	`get { self[K.self] }`
`38`	`39`	`set { self[K.self] = newValue }`
Original file line number	Diff line number	Diff line change
`@@ -243,6 +243,7 @@ extension AttributedString: AttributedStringProtocol {`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`@preconcurrency`
	`246`	`+ @inlinable // Trivial implementation, allows callers to optimize away the keypath allocation`
`246`	`247`	`public subscript<K: AttributedStringKey>(`
`247`	`248`	`dynamicMember keyPath: KeyPath<AttributeDynamicLookup, K>`
`248`	`249`	`) -> K.Value? where K.Value: Sendable {`
Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,7 @@ extension AttributedSubstring {`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`@preconcurrency`
	`180`	`+ @inlinable // Trivial implementation, allows callers to optimize away the keypath allocation`
`180`	`181`	`public subscript<K: AttributedStringKey>(`
`181`	`182`	`dynamicMember keyPath: KeyPath<AttributeDynamicLookup, K>`
`182`	`183`	`) -> K.Value? where K.Value : Sendable {`
Original file line number	Diff line number	Diff line change
`@@ -194,6 +194,7 @@ extension DiscontiguousAttributedSubstring {`
`194`	`194`	`}`
`195`	`195`	`}`
`196`	`196`
	`197`	`+ @inlinable // Trivial implementation, allows callers to optimize away the keypath allocation`
`197`	`198`	`public subscript<K: AttributedStringKey>(`
`198`	`199`	`dynamicMember keyPath: KeyPath<AttributeDynamicLookup, K>`
`199`	`200`	`) -> K.Value? where K.Value : Sendable {`