Retrieving attributed string attribute values should not use identity casts #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use identity casts
|
@swift-ci please test |
parkera
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a small portion of #1287. It's not always possible to use an identity cast here, because in some cases (such as catalyst applications where
AttributedStrings interchangeably use both UIKitUIColorand AppKitNSColorattributes) we do rely on dynamic casting behavior. The dynamic cast should attempt an identity cast first so this shouldn't have a strong impact on the overall performance win since we still avoid the optional boxing in__equalAttributesand retain the performance wins from the runs view.