Skip to content

Commit 8a500a0

Browse files
committed
WiX: simplify the Android ARMv7 rules
The Android ARMv7 build will properly install the modules at this point without a separate triple for the modules. Update the rules accordingly bringing the ARMv7 inline with the other Android SDKs. The only outlier remaining would be `ds2` which should adopt the same triple.
1 parent 33f0009 commit 8a500a0

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

platforms/Windows/sdk/drd/sdk.wxs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33

44
<?if $(ProductArchitecture) = "arm64"?>
55
<?define Architecture = "aarch64"?>
6-
<?define SwiftModuleTriple = "aarch64-unknown-linux-android"?>
76
<?define Triple = "aarch64-unknown-linux-android"?>
87
<?elseif $(ProductArchitecture) = "amd64"?>
98
<?define Architecture = "x86_64"?>
10-
<?define SwiftModuleTriple = "x86_64-unknown-linux-android"?>
119
<?define Triple = "x86_64-unknown-linux-android"?>
1210
<?elseif $(ProductArchitecture) = "arm"?>
1311
<?define Architecture = "armv7"?>
@@ -20,11 +18,9 @@
2018
TODO: consider updating Swift compiler to output file names matching the
2119
correct triple.
2220
-->
23-
<?define SwiftModuleTriple = "armv7-unknown-linux-androideabi"?>
2421
<?define Triple = "armv7-unknown-linux-android"?>
2522
<?elseif $(ProductArchitecture) = "x86"?>
2623
<?define Architecture = "i686"?>
27-
<?define SwiftModuleTriple = "i686-unknown-linux-android"?>
2824
<?define Triple = "i686-unknown-linux-android"?>
2925
<?endif?>
3026

@@ -150,10 +146,10 @@
150146
<File Source="$(PLATFORM_ROOT)\Developer\Library\XCTest-$(ProductVersion)\usr\lib\swift\android\$(Architecture)\libXCTest.so" />
151147
</Component>
152148
<Component Directory="XCTest.swiftmodule">
153-
<File Source="$(PLATFORM_ROOT)\Developer\Library\XCTest-$(ProductVersion)\usr\lib\swift\android\XCTest.swiftmodule\$(SwiftModuleTriple).swiftdoc" />
149+
<File Source="$(PLATFORM_ROOT)\Developer\Library\XCTest-$(ProductVersion)\usr\lib\swift\android\XCTest.swiftmodule\$(Triple).swiftdoc" />
154150
</Component>
155151
<Component Directory="XCTest.swiftmodule">
156-
<File Source="$(PLATFORM_ROOT)\Developer\Library\XCTest-$(ProductVersion)\usr\lib\swift\android\XCTest.swiftmodule\$(SwiftModuleTriple).swiftmodule" />
152+
<File Source="$(PLATFORM_ROOT)\Developer\Library\XCTest-$(ProductVersion)\usr\lib\swift\android\XCTest.swiftmodule\$(Triple).swiftmodule" />
157153
</Component>
158154
</ComponentGroup>
159155

@@ -172,7 +168,7 @@
172168
<ComponentGroup Id="DS2">
173169
<?if $(ANDROID_INCLUDE_DS2) == true ?>
174170
<Component Directory="_ds2_usr_bin">
175-
<File Source="$(PLATFORM_ROOT)\Developer\Library\ds2\usr\bin\$(SwiftModuleTriple)-ds2" />
171+
<File Source="$(PLATFORM_ROOT)\Developer\Library\ds2\usr\bin\$(Triple)-ds2" />
176172
</Component>
177173
<?endif?>
178174
</ComponentGroup>

0 commit comments

Comments
 (0)