Add tests, refine Destination and DestinationInfoV2

Author: MaxDesiatov

Sources/PackageModel/Destination.swift

@@ -259,7 +259,7 @@ public struct Destination: Encodable, Equatable {
 }
 
 extension Destination {
-    /// Load a Destination description from a JSON representation from disk.
+    /// Load a ``Destination`` description from a JSON representation from disk.
     public init(fromFile path: AbsolutePath, fileSystem: FileSystem) throws {
         let decoder = JSONDecoder.makeWithDefaults()
         let version = try decoder.decode(path: path, fileSystem: fileSystem, as: VersionInfo.self)
@@ -269,9 +269,9 @@ extension Destination {
         case 1:
             let destination = try decoder.decode(path: path, fileSystem: fileSystem, as: DestinationInfoV1.self)
             try self.init(
-                target: destination.target.map{ try Triple($0) },
-                sdk: destination.sdk,
-                binDir: destination.binDir,
+                destinationTriple: destination.target.map{ try Triple($0) },
+                sdkRootDir: destination.sdk,
+                toolchainBinDir: destination.binDir,
                 extraFlags: .init(
                     cCompilerFlags: destination.extraCCFlags,
                     cxxCompilerFlags: destination.extraCPPFlags,
@@ -283,9 +283,10 @@ extension Destination {
             let destinationDirectory = path.parentDirectory
 
             try self.init(
-                target: Triple(destination.destinationTriple),
-                sdk: AbsolutePath(validating: destination.sdkDir, relativeTo: destinationDirectory),
-                binDir: AbsolutePath(validating: destination.toolchainBinDir, relativeTo: destinationDirectory),
+                hostTriple: Triple(destination.hostTriple),
+                destinationTriple: Triple(destination.destinationTriple),
+                sdkRootDir: AbsolutePath(validating: destination.sdkDir, relativeTo: destinationDirectory),
+                toolchainBinDir: AbsolutePath(validating: destination.toolchainBinDir, relativeTo: destinationDirectory),
                 extraFlags: .init(
                     cCompilerFlags: destination.extraCCFlags,
                     cxxCompilerFlags: destination.extraCPPFlags,

Sources/PackageModel/Manifest.swift

@@ -180,14 +180,14 @@ public final class Manifest {
         }
 
         var requiredDependencies: Set<PackageIdentity> = []
-        for target in self.targetsRequired(for: products) {
-            for targetDependency in target.dependencies {
+        for destinationTriple in self.targetsRequired(for: products) {
+            for targetDependency in destinationTriple.dependencies {
                 if let dependency = self.packageDependency(referencedBy: targetDependency) {
                     requiredDependencies.insert(dependency.identity)
                 }
             }
 
-            target.pluginUsages?.forEach {
+            destinationTriple.pluginUsages?.forEach {
                 if let dependency = self.packageDependency(referencedBy: $0) {
                     requiredDependencies.insert(dependency.identity)
                 }

Sources/PackageModel/UserToolchain.swift

@@ -258,7 +258,7 @@ public final class UserToolchain: Toolchain {
     }
 
     internal static func deriveSwiftCFlags(triple: Triple, destination: Destination, environment: EnvironmentVariables) throws -> [String] {
-        guard let sdk = destination.sdkRootDir else {
+        guard let sdkDir = destination.sdkRootDir else {
             if triple.isWindows() {
                 // Windows uses a variable named SDKROOT to determine the root of
                 // the SDK.  This is not the same value as the SDKROOT parameter
@@ -336,7 +336,7 @@ public final class UserToolchain: Toolchain {
         }
 
         return (triple.isDarwin() || triple.isAndroid() || triple.isWASI() || triple.isWindows()
-                ? ["-sdk", sdk.pathString]
+                ? ["-sdk", sdkDir.pathString]
                 : [])
         + destination.extraFlags.swiftCompilerFlags
     }
@@ -389,9 +389,9 @@ public final class UserToolchain: Toolchain {
 
         self.extraFlags.swiftCompilerFlags = try Self.deriveSwiftCFlags(triple: triple, destination: destination, environment: environment)
 
-        if let sdk = destination.sdkRootDir {
+        if let sdkDir = destination.sdkRootDir {
             self.extraFlags.cCompilerFlags = [
-                triple.isDarwin() ? "-isysroot" : "--sysroot", sdk.pathString
+                triple.isDarwin() ? "-isysroot" : "--sysroot", sdkDir.pathString
             ] + destination.extraFlags.cCompilerFlags
 
             self.extraFlags.cxxCompilerFlags = destination.extraFlags.cxxCompilerFlags
@@ -521,12 +521,12 @@ public final class UserToolchain: Toolchain {
                 return try AbsolutePath(validating: path)
             }
         } else if triple.isWindows() {
-            let sdkroot: AbsolutePath
+            let sdkRoot: AbsolutePath
 
-            if let sdk = destination.sdkRootDir {
-                sdkroot = sdk
-            } else if let SDKROOT = environment["SDKROOT"], let sdk = try? AbsolutePath(validating: SDKROOT) {
-                sdkroot = sdk
+            if let sdkDir = destination.sdkRootDir {
+                sdkRoot = sdkDir
+            } else if let SDKROOT = environment["SDKROOT"], let sdkDir = try? AbsolutePath(validating: SDKROOT) {
+                sdkRoot = sdkDir
             } else {
                 return .none
             }
@@ -537,7 +537,7 @@ public final class UserToolchain: Toolchain {
             // Library/Developer/Platforms/[PLATFORM].platform/Developer/SDKs/[PLATFORM].sdk/...
             //
             // SDKROOT points to [PLATFORM].sdk
-            let platform = sdkroot.parentDirectory.parentDirectory.parentDirectory
+            let platform = sdkRoot.parentDirectory.parentDirectory.parentDirectory
 
             if let info = WindowsPlatformInfo(reading: platform.appending(component: "Info.plist"),
                                               diagnostics: nil, filesystem: localFileSystem) {

Tests/PackageModelTests/DestinationTests.swift

@@ -0,0 +1,62 @@
+//===----------------------------------------------------------------------===//
+//
+// This source file is part of the Swift open source project
+//
+// Copyright (c) 2014-2022 Apple Inc. and the Swift project authors
+// Licensed under Apache License v2.0 with Runtime Library Exception
+//
+// See http://swift.org/LICENSE.txt for license information
+// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+//
+//===----------------------------------------------------------------------===//
+
+import Basics
+@testable import PackageModel
+import TSCBasic
+import TSCUtility
+import XCTest
+
+private let bundleRootPath = try! AbsolutePath(validating: "/tmp/cross-toolchain")
+private let toolchainBinDir = bundleRootPath.appending(.init("swift.xctoolchain/usr/bin"))
+private let sdkRootDir = bundleRootPath.appending(.init("ubuntu-jammy.sdk"))
+private let destinationTriple = "x86_64-unknown-linux-gnu"
+private let extraFlags = BuildFlags(
+    cCompilerFlags: ["-fintegrated-as"],
+    cxxCompilerFlags: ["-fno-exceptions"],
+    swiftCompilerFlags: ["-enable-experimental-cxx-interop", "-use-ld=lld"],
+    linkerFlags: ["-R/usr/lib/swift/linux/"]
+)
+
+private let destinationV1JSON =
+    #"""
+    {
+        "version": 1,
+        "sdk": "\#(sdkRootDir)",
+        "toolchain-bin-dir": "\#(toolchainBinDir)",
+        "target": "\#(destinationTriple)",
+        "extra-cc-flags": \#(extraFlags.cCompilerFlags),
+        "extra-swiftc-flags": \#(extraFlags.swiftCompilerFlags),
+        "extra-cpp-flags": \#(extraFlags.cxxCompilerFlags)
+    }
+    """#
+
+class DestinationTests: XCTestCase {
+    func testDestinationCodable() throws {
+        let fs = InMemoryFileSystem(files: ["/sdk/destination.json": ByteString(encodingAsUTF8: destinationV1JSON)])
+
+        let destinationV1 = try Destination(fromFile: AbsolutePath(validating: "/sdk/destination.json"), fileSystem: fs)
+
+        var flagsWithoutLinkerFlags = extraFlags
+        flagsWithoutLinkerFlags.linkerFlags = []
+
+        XCTAssertEqual(
+            destinationV1,
+            Destination(
+                destinationTriple: try Triple(destinationTriple),
+                sdkRootDir: sdkRootDir,
+                toolchainBinDir: toolchainBinDir,
+                extraFlags: flagsWithoutLinkerFlags
+            )
+        )
+    }
+}

Tests/PackageModelTests/PackageModelTests.swift

@@ -57,18 +57,18 @@ class PackageModelTests: XCTestCase {
 
     func testAndroidCompilerFlags() throws {
         let triple = try Triple("x86_64-unknown-linux-android")
-        let sdk = AbsolutePath(path: "/some/path/to/an/SDK.sdk")
+        let sdkDir = AbsolutePath(path: "/some/path/to/an/SDK.sdk")
         let toolchainPath = AbsolutePath(path: "/some/path/to/a/toolchain.xctoolchain")
 
         let destination = Destination(
             destinationTriple: triple,
-            sdkRootDir: sdk,
+            sdkRootDir: sdkDir,
             toolchainBinDir: toolchainPath.appending(components: "usr", "bin")
         )
 
         XCTAssertEqual(try UserToolchain.deriveSwiftCFlags(triple: triple, destination: destination, environment: .process()), [
             // Needed when cross‐compiling for Android. 2020‐03‐01
-            "-sdk", sdk.pathString,
+            "-sdk", sdkDir.pathString,
         ])
     }
 }