Skip to content

Commit 0e40ba1

Browse files
authored
Fix ShellCheck warning in CC SDK script for Ubuntu (#5865)
In the original code, the return value of `brew` is ignored, and export will instead always return true. This may prevent conditionals, `set -e` and traps from working correctly.
1 parent 59dc518 commit 0e40ba1

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Utilities/build_ubuntu_cross_compilation_toolchain

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313

1414
set -eu
1515

16-
export PATH="/bin:/usr/bin:$(brew --prefix)/bin"
16+
PATH="/bin:/usr/bin:$(brew --prefix)/bin"
17+
export PATH
1718
VERSION=${VERSION:-5.7-RELEASE}
1819
if [[ -z "${VERSION##*RELEASE*}" ]]; then
1920
branch=swift-${VERSION%%RELEASE}release

0 commit comments

Comments
 (0)