Remove the DispatchTimeInterval extension that adds asSeconds and instead make the similar one in Basics public and use it, based on review feedback.

Author: abertelrud

Sources/Basics/DispatchTimeInterval+Extensions.swift

@@ -1,7 +1,7 @@
 /*
  This source file is part of the Swift.org open source project
 
- Copyright (c) 2020 Apple Inc. and the Swift project authors
+ Copyright (c) 2020-2022 Apple Inc. and the Swift project authors
  Licensed under Apache License v2.0 with Runtime Library Exception
 
  See http://swift.org/LICENSE.txt for license information
@@ -12,7 +12,7 @@ import Dispatch
 import struct Foundation.TimeInterval
 
 extension DispatchTimeInterval {
-    func timeInterval() -> TimeInterval? {
+    public func timeInterval() -> TimeInterval? {
         switch self {
         case .seconds(let value):
             return Double(value)
@@ -27,7 +27,7 @@ extension DispatchTimeInterval {
         }
     }
 
-    func milliseconds() -> Int? {
+    public func milliseconds() -> Int? {
         switch self {
         case .seconds(let value):
             return value.multipliedReportingOverflow(by: 1000).partialValue
@@ -42,7 +42,7 @@ extension DispatchTimeInterval {
         }
     }
 
-    func seconds() -> Int? {
+    public func seconds() -> Int? {
         switch self {
         case .seconds(let value):
             return value

Sources/Commands/SwiftTestTool.swift

@@ -1198,7 +1198,7 @@ extension SwiftTestTool {
                         // Run the test — for now we run the sequentially so we can capture accurate timing results.
                         let startTime = DispatchTime.now()
                         let (success, _) = testRunner.test(writeToOutputStream: false)
-                        let duration = startTime.distance(to: .now()).asSeconds ?? 0.0
+                        let duration = Double(startTime.distance(to: .now()).milliseconds() ?? 0) / 1000.0
                         numFailedTests += success ? 0 : 1
                         testResults.append(.init(name: testName, result: success ? .succeeded : .failed, duration: duration))
                     }
@@ -1261,20 +1261,3 @@ extension SwiftTestTool {
             codeCoverageDataFile: codeCoverageDataFile?.pathString)
     }
 }
-
-fileprivate extension DispatchTimeInterval {
-    var asSeconds: Double? {
-        switch self {
-        case .seconds(let value):
-            return Double(value)
-        case .milliseconds(let value):
-            return Double(value) / 1000
-        case .microseconds(let value):
-            return Double(value) / 1_000_000
-        case .nanoseconds(let value):
-            return Double(value) / 1_000_000_000
-        default:
-            return .none
-        }
-    }
-}