Skip to content

Commit 164ea53

Browse files
committed
deprecate validation that a resource localization exists for the default langauge
motivatoin: the warning is redundant changes: * remove the validation for the default langauge * adjust test * refactor TargetSourcesBuilderTests so we can test for no diagnostics rdar://86297221
1 parent a783689 commit 164ea53

File tree

2 files changed

+152
-120
lines changed

2 files changed

+152
-120
lines changed

Sources/PackageLoading/TargetSourcesBuilder.swift

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,12 @@ public struct TargetSourcesBuilder {
328328
return
329329
}
330330

331+
// rdar://86297221
332+
// There is no need to validate for english, because the string key is already in english
333+
if self.defaultLocalization == "en" {
334+
return
335+
}
336+
331337
let localizedResources = resources.lazy.filter({ $0.localization != nil && $0.localization != "Base" })
332338
let resourcesByBasename = Dictionary(grouping: localizedResources, by: { $0.path.basename })
333339
for (basename, resources) in resourcesByBasename {

0 commit comments

Comments
 (0)