Basic: replace symlink with Foundation

compnerd · aciidgh · commit 1bba4b3e1d13 · 2019-08-12T10:22:16.000-07:00
Use `createSymbolicLink` from Foundation rather than using `symlink`
from the C library which is not portable (Windows does not provide
`symlink`).
diff --git a/Sources/Basic/PathShims.swift b/Sources/Basic/PathShims.swift
@@ -45,8 +45,7 @@ public func makeDirectories(_ path: AbsolutePath) throws {
 /// be a relative path, otherwise it will be absolute.
 public func createSymlink(_ path: AbsolutePath, pointingAt dest: AbsolutePath, relative: Bool = true) throws {
     let destString = relative ? dest.relative(to: path.parentDirectory).pathString : dest.pathString
-    let rv = SPMLibc.symlink(destString, path.pathString)
-    guard rv == 0 else { throw SystemError.symlink(errno, path.pathString, dest: destString) }
+    try FileManager.default.createSymbolicLink(atPath: path.pathString, withDestinationPath: destString)
 }
 
 /// The current working directory of the processs.

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,7 @@ public func makeDirectories(_ path: AbsolutePath) throws {`
`45`	`45`	`/// be a relative path, otherwise it will be absolute.`
`46`	`46`	`public func createSymlink(_ path: AbsolutePath, pointingAt dest: AbsolutePath, relative: Bool = true) throws {`
`47`	`47`	`let destString = relative ? dest.relative(to: path.parentDirectory).pathString : dest.pathString`
`48`		`- let rv = SPMLibc.symlink(destString, path.pathString)`
`49`		`- guard rv == 0 else { throw SystemError.symlink(errno, path.pathString, dest: destString) }`
	`48`	`+ try FileManager.default.createSymbolicLink(atPath: path.pathString, withDestinationPath: destString)`
`50`	`49`	`}`
`51`	`50`
`52`	`51`	`/// The current working directory of the processs.`