Skip to content

Commit 201198a

Browse files
authored
Unskip swiftbuild tests that previously failed due to missing dsymutil (#8879)
Until[swift-build#607](swiftlang/swift-build#607) was merged, there was an error due to a missing dsymutil tool on non-macOS system, such as Linux. Remove the skip from the tests now that this is working. Fixes #8862
1 parent cdb5674 commit 201198a

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

Tests/CommandsTests/PackageCommandTests.swift

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2845,10 +2845,6 @@ class PackageCommandTestCase: CommandsBuildProviderTestCase {
28452845
AssertNotExists(fixturePath.appending(components: releaseTarget))
28462846
}
28472847

2848-
if self.buildSystemProvider == .swiftbuild && ProcessInfo.hostOperatingSystem != .macOS {
2849-
throw XCTSkip("Failed to find dsymutil tool: https://github.com/swiftlang/swift-package-manager/issues/8862")
2850-
}
2851-
28522848
// If the plugin requests a release binary, that is what will be built, regardless of overall configuration
28532849
try await fixture(name: "Miscellaneous/Plugins/CommandPluginTestStub") { fixturePath in
28542850
let _ = try await self.execute(["-c", "debug", "build-target", "build-release"], packagePath: fixturePath)
@@ -2880,8 +2876,6 @@ class PackageCommandTestCase: CommandsBuildProviderTestCase {
28802876
await XCTAssertAsyncNoThrow(try await self.execute(["-c", "debug", "check-testability", "InternalModule", "debug", "true"], packagePath: fixturePath))
28812877
}
28822878

2883-
if buildSystemProvider == .swiftbuild && ProcessInfo.hostOperatingSystem != .macOS { throw XCTSkip("Failed to find dsymutil tool: https://github.com/swiftlang/swift-package-manager/issues/8862") }
2884-
28852879
// Overall configuration: debug, plugin build request: release -> without testability
28862880
try await fixture(name: "Miscellaneous/Plugins/CommandPluginTestStub") { fixturePath in
28872881
await XCTAssertAsyncNoThrow(try await self.execute(["-c", "debug", "check-testability", "InternalModule", "release", "false"], packagePath: fixturePath))
@@ -3514,11 +3508,6 @@ class PackageCommandTestCase: CommandsBuildProviderTestCase {
35143508
XCTFail("unimplemented assertion for --build-system xcode")
35153509
}
35163510
XCTAssertMatch(stdout, .and(.contains("artifact-kind:"), .contains("executable")))
3517-
} catch {
3518-
if ProcessInfo.hostOperatingSystem != .macOS && self.buildSystemProvider == .swiftbuild {
3519-
throw XCTSkip("Failed to find dsymutil tool: https://github.com/swiftlang/swift-package-manager/issues/8862")
3520-
}
3521-
throw error
35223511
}
35233512

35243513
// Invoke the plugin with parameters choosing a verbose build of MyStaticLibrary for release.
@@ -3540,11 +3529,6 @@ class PackageCommandTestCase: CommandsBuildProviderTestCase {
35403529
XCTFail("unimplemented assertion for --build-system xcode")
35413530
}
35423531
XCTAssertMatch(stdout, .and(.contains("artifact-kind:"), .contains("staticLibrary")))
3543-
} catch {
3544-
if ProcessInfo.hostOperatingSystem != .macOS && self.buildSystemProvider == .swiftbuild {
3545-
throw XCTSkip("Failed to find dsymutil tool: https://github.com/swiftlang/swift-package-manager/issues/8862")
3546-
}
3547-
throw error
35483532
}
35493533

35503534
// Invoke the plugin with parameters choosing a verbose build of MyDynamicLibrary for release.
@@ -3570,11 +3554,6 @@ class PackageCommandTestCase: CommandsBuildProviderTestCase {
35703554
XCTFail("unimplemented assertion for --build-system xcode")
35713555
}
35723556
XCTAssertMatch(stdout, .and(.contains("artifact-kind:"), .contains("dynamicLibrary")))
3573-
} catch {
3574-
if ProcessInfo.hostOperatingSystem != .macOS && self.buildSystemProvider == .swiftbuild {
3575-
throw XCTSkip("Failed to find dsymutil tool: https://github.com/swiftlang/swift-package-manager/issues/8862")
3576-
}
3577-
throw error
35783557
}
35793558
}
35803559
}

0 commit comments

Comments
 (0)