Changed name from C99 to C99ExtendedIdentifier to make things more

clear, based on feedback.

Author: abertelrud

Sources/Basic/StringConversions.swift

@@ -76,7 +76,7 @@ public extension String {
 
     /// Creates a string that contains only value C99 characters.
     /// FIXME: We will likely want a better name...
-    public func mangledForC99() -> String {
+    public func mangledToC99ExtendedIdentifier() -> String {
         // Map invalid C99-invalid Unicode scalars to a replacement character.
         let replacementUnichar: UnicodeScalar = "_"
         var mangledUnichars: [UnicodeScalar] = self.unicodeScalars.map {

Sources/Commands/init.swift

@@ -56,7 +56,7 @@ final class InitPackage {
     init(mode: InitMode) throws {
         self.mode = mode
         self.pkgname = rootd.basename
-        self.moduleName = rootd.basename.mangledForC99()
+        self.moduleName = rootd.basename.mangledToC99ExtendedIdentifier()
     }
 
     func writePackageStructure() throws {

Sources/PackageModel/Module.swift

@@ -63,7 +63,7 @@ public class Module: ModuleProtocol {
         self.type = type
         self.sources = sources
         self.dependencies = []
-        self.c99name = self.name.mangledForC99()
+        self.c99name = self.name.mangledToC99ExtendedIdentifier()
         self.isTest = isTest
     }
 

Tests/Basic/StringConversionsTests.swift

@@ -41,20 +41,20 @@ class StringConversionTests: XCTestCase {
     func testManglingForC99() {
 
         // Simple cases.
-        XCTAssertEqual("foo".mangledForC99(), "foo")
+        XCTAssertEqual("foo".mangledToC99ExtendedIdentifier(), "foo")
 
         // Edge cases.
-        XCTAssertEqual("".mangledForC99(), "")
-        XCTAssertEqual("_".mangledForC99(), "_")
-        XCTAssertEqual("\n".mangledForC99(), "_")
+        XCTAssertEqual("".mangledToC99ExtendedIdentifier(), "")
+        XCTAssertEqual("_".mangledToC99ExtendedIdentifier(), "_")
+        XCTAssertEqual("\n".mangledToC99ExtendedIdentifier(), "_")
 
         // Invalid non-leading characters.
-        XCTAssertEqual("_-".mangledForC99(), "__")
-        XCTAssertEqual("foo-bar".mangledForC99(), "foo_bar")
+        XCTAssertEqual("_-".mangledToC99ExtendedIdentifier(), "__")
+        XCTAssertEqual("foo-bar".mangledToC99ExtendedIdentifier(), "foo_bar")
 
         // Invalid leading characters.
-        XCTAssertEqual("1".mangledForC99(), "_")
-        XCTAssertEqual("1foo".mangledForC99(), "_foo")
+        XCTAssertEqual("1".mangledToC99ExtendedIdentifier(), "_")
+        XCTAssertEqual("1foo".mangledToC99ExtendedIdentifier(), "_foo")
 
         // FIXME: There are lots more interesting test cases to add here.
     }