Merge pull request #268 from mxcl/warning--

--warning (@NoEscape moved to parameter)

Author: ddunbar

Sources/POSIX/mkdtemp.swift

@@ -18,7 +18,7 @@ import func libc.rmdir
  - Note: We only call rmdir() on the directory once done, it is up to
  you to recursively delete the contents and thus ensure the rmdir succeeds
 */
-public func mkdtemp<T>(_ template: String, prefix: String! = nil, @noescape body: (String) throws -> T) rethrows -> T {
+public func mkdtemp<T>(_ template: String, prefix: String! = nil, body: @noescape(String) throws -> T) rethrows -> T {
     var prefix = prefix
     if prefix == nil { prefix = getenv("TMPDIR") ?? "/tmp/" }
     if !prefix.hasSuffix("/") {

Tests/Functional/Utilities.swift

@@ -21,7 +21,7 @@ import class Foundation.NSBundle
 #endif
 
 
-func fixture(name fixtureName: String, tags: [String] = [], file: StaticString = #file, line: UInt = #line, @noescape body: (String) throws -> Void) {
+func fixture(name fixtureName: String, tags: [String] = [], file: StaticString = #file, line: UInt = #line, body: @noescape(String) throws -> Void) {
 
     func gsub(_ input: String) -> String {
         return input.characters.split(separator: "/").map(String.init).joined(separator: "_")
@@ -155,7 +155,7 @@ func executeSwiftBuild(_ chdir: String, configuration: Configuration = .Debug, p
     }
 }
 
-func mktmpdir(_ file: StaticString = #file, line: UInt = #line, @noescape body: (String) throws -> Void) {
+func mktmpdir(_ file: StaticString = #file, line: UInt = #line, body: @noescape(String) throws -> Void) {
     do {
         try POSIX.mkdtemp("spm-tests") { dir in
             defer { _ = try? rmtree(dir) }

Tests/Functional/ValidLayoutTests.swift

@@ -99,7 +99,7 @@ class ValidLayoutsTestCase: XCTestCase {
 //MARK: Utility
 
 extension ValidLayoutsTestCase {
-    func runLayoutFixture(name: String, line: UInt = #line, @noescape body: (String) throws -> Void) {
+    func runLayoutFixture(name: String, line: UInt = #line, body: @noescape(String) throws -> Void) {
         let name = "ValidLayouts/\(name)"
 
         // 1. Rooted layout

Tests/PackageDescription/VersionTests.swift

@@ -15,7 +15,7 @@ import XCTest
 class VersionTests: XCTestCase {
 
     func testEquality() {
-        func test(@autoclosure _ v: () -> Version) {
+        func test( _ v: @autoclosure() -> Version) {
             XCTAssertEqual(v(), v())
         }
 

Tests/Xcodeproj/GenerateXcodeprojTests.swift

@@ -16,7 +16,7 @@ import XCTest
 
 
 // copy pasta
-func mktmpdir(_ file: StaticString = #file, line: UInt = #line, @noescape body: (String) throws -> Void) {
+func mktmpdir(_ file: StaticString = #file, line: UInt = #line, body: @noescape(String) throws -> Void) {
     do {
         try POSIX.mkdtemp("spm-tests") { dir in
             defer { _ = try? rmtree(dir) }