fatal error if attempting to use dynamic libraries on os none

Author: rauhul

Sources/Basics/Triple.swift

@@ -263,10 +263,7 @@ extension Triple {
         case .wasi:
             return ".wasm"
         case .noneOS:
-            // Better as dynamic error or "fatalError", but it is a larger
-            // undertaking to teach spm that dylibs are not available on some
-            // platforms.
-            return ".os-none-dynamic-library"
+            fatalError("Cannot create dynamic libraries for os \"none\".")
         }
     }
 

Sources/SPMBuildCore/BuildParameters.swift

@@ -394,15 +394,16 @@ public struct BuildParameters: Encodable {
     /// Returns the path to the binary of a product for the current build parameters, relative to the build directory.
     public func binaryRelativePath(for product: ResolvedProduct) -> RelativePath {
         let potentialExecutablePath = RelativePath("\(product.name)\(triple.executableExtension)")
-        let potentialLibraryPath = RelativePath("\(triple.dynamicLibraryPrefix)\(product.name)\(triple.dynamicLibraryExtension)")
+        func potentialLibraryPath() -> RelativePath { RelativePath("\(triple.dynamicLibraryPrefix)\(product.name)\(triple.dynamicLibraryExtension)")
+        }
 
         switch product.type {
         case .executable, .snippet:
             return potentialExecutablePath
         case .library(.static):
             return RelativePath("lib\(product.name)\(triple.staticLibraryExtension)")
         case .library(.dynamic):
-            return potentialLibraryPath
+            return potentialLibraryPath()
         case .library(.automatic), .plugin:
             fatalError()
         case .test:
@@ -418,7 +419,7 @@ public struct BuildParameters: Encodable {
             }
         case .macro:
             #if BUILD_MACROS_AS_DYLIBS
-            return potentialLibraryPath
+            return potentialLibraryPath()
             #else
             return potentialExecutablePath
             #endif