Escape filename backslashes when generating Manifest DOT graph.

artemcm · artemcm · commit 4b545be9a4f4 · 2020-07-06T11:41:51.000-07:00
diff --git a/Sources/LLBuildManifest/DOTManifestSerializer.swift b/Sources/LLBuildManifest/DOTManifestSerializer.swift
@@ -32,9 +32,10 @@ public struct DOTManifestSerializer {
         return label
     }
 
-    /// Quote the name and escape the quotes
+    /// Quote the name and escape the quotes and backslashes
     func quoteName(_ name: String) -> String {
-        return "\"" + name.replacingOccurrences(of: "\"", with: "\\\"") + "\""
+        return "\"" + name.replacingOccurrences(of: "\"", with: "\\\"")
+                          .replacingOccurrences(of: "\\", with: "\\\\") + "\""
     }
 
     public mutating func writeDOT<Stream: TextOutputStream>(to stream: inout Stream) {

Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,10 @@ public struct DOTManifestSerializer {`
`32`	`32`	`return label`
`33`	`33`	`}`
`34`	`34`
`35`		`- /// Quote the name and escape the quotes`
	`35`	`+ /// Quote the name and escape the quotes and backslashes`
`36`	`36`	`func quoteName(_ name: String) -> String {`
`37`		`- return "\"" + name.replacingOccurrences(of: "\"", with: "\\\"") + "\""`
	`37`	`+ return "\"" + name.replacingOccurrences(of: "\"", with: "\\\"")`
	`38`	`+ .replacingOccurrences(of: "\\", with: "\\\\") + "\""`
`38`	`39`	`}`
`39`	`40`
`40`	`41`	`public mutating func writeDOT<Stream: TextOutputStream>(to stream: inout Stream) {`