Skip to content

Commit 518d777

Browse files
committed
Revert "Reenable disabled tests (#5957)"
This reverts commit c6faab7. The failure showed up again in #5950, so it's not actually gone.
1 parent 1c9477e commit 518d777

File tree

6 files changed

+13
-6
lines changed

6 files changed

+13
-6
lines changed

Package.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,8 @@ let package = Package(
507507
name: "WorkspaceTests",
508508
dependencies: ["Workspace", "SPMTestSupport"]
509509
),
510-
.testTarget(
510+
// rdar://101868275 "error: cannot find 'XCTAssertEqual' in scope" can affect almost any functional test, so we flat out disable them all until we know what is going on
511+
/*.testTarget(
511512
name: "FunctionalTests",
512513
dependencies: [
513514
"swift-build",
@@ -516,7 +517,7 @@ let package = Package(
516517
"PackageModel",
517518
"SPMTestSupport"
518519
]
519-
),
520+
),*/
520521
.testTarget(
521522
name: "FunctionalPerformanceTests",
522523
dependencies: [

Tests/CommandsTests/BuildToolTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ final class BuildToolTests: CommandsTestCase {
280280
}
281281

282282
func testBuildCompleteMessage() throws {
283-
throw XCTSkip("This test isn't stable w.r.t. the build cache; rdar://101815761")
283+
throw XCTSkip("This test fails to match the 'Compiling' regex; rdar://101815761")
284284

285285
try fixture(name: "DependencyResolution/Internal/Simple") { fixturePath in
286286
do {

Tests/FunctionalTests/PluginTests.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,6 @@ class PluginTests: XCTestCase {
461461
outputDirectory: pluginDir.appending(component: "output"),
462462
toolSearchDirectories: toolSearchDirectories,
463463
toolNamesToPaths: [:],
464-
toolNamesToTriples: [:],
465464
writableDirectories: [pluginDir.appending(component: "output")],
466465
readOnlyDirectories: [package.path],
467466
fileSystem: localFileSystem,
@@ -723,7 +722,6 @@ class PluginTests: XCTestCase {
723722
outputDirectory: pluginDir.appending(component: "output"),
724723
toolSearchDirectories: [try UserToolchain.default.swiftCompilerPath.parentDirectory],
725724
toolNamesToPaths: [:],
726-
toolNamesToTriples: [:],
727725
writableDirectories: [pluginDir.appending(component: "output")],
728726
readOnlyDirectories: [package.path],
729727
fileSystem: localFileSystem,

Tests/WorkspaceTests/InitTests.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,8 @@ class InitTests: XCTestCase {
266266
}
267267

268268
func testNonC99NameExecutablePackage() throws {
269+
throw XCTSkip("This test fails to find XCTAssertEqual; rdar://101868275")
270+
269271
try withTemporaryDirectory(removeTreeOnDeinit: true) { tempDirPath in
270272
XCTAssertDirectoryExists(tempDirPath)
271273

Tests/WorkspaceTests/WorkspaceTests.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4291,6 +4291,8 @@ final class WorkspaceTests: XCTestCase {
42914291

42924292
// This verifies that the simplest possible loading APIs are available for package clients.
42934293
func testSimpleAPI() throws {
4294+
throw XCTSkip("This test fails to find XCTAssertEqual; rdar://101868275")
4295+
42944296
try testWithTemporaryDirectory { path in
42954297
// Create a temporary package as a test case.
42964298
let packagePath = path.appending(component: "MyPkg")

Utilities/bootstrap

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,11 @@ def test(args):
361361

362362
note("Testing")
363363
parse_test_args(args)
364-
cmd = [os.path.join(args.bin_dir, "swift-test")]
364+
cmd = [
365+
"SWIFT_EXEC=" + args.swiftc_path,
366+
"SWIFT_DRIVER_SWIFT_EXEC=" + args.swiftc_path,
367+
os.path.join(args.bin_dir, "swift-test")
368+
]
365369
if args.parallel:
366370
cmd.append("--parallel")
367371
for arg in args.filter:

0 commit comments

Comments
 (0)