Change default FingerprintCheckingMode to 'strict' (#4304)

rdar://85989302

Author: yim-lee

Sources/Commands/Options.swift

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift open source project
 //
-// Copyright (c) 2014-2021 Apple Inc. and the Swift project authors
+// Copyright (c) 2014-2022 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See http://swift.org/LICENSE.txt for license information
@@ -176,7 +176,7 @@ struct SecurityOptions: ParsableArguments {
     #endif
 
     @Option(name: .customLong("resolver-fingerprint-checking"))
-    var fingerprintCheckingMode: FingerprintCheckingMode = .warn
+    var fingerprintCheckingMode: FingerprintCheckingMode = .strict
 
     @Flag(name: .customLong("netrc"), help: .hidden)
     var _deprecated_netrc: Bool = false

Sources/Workspace/Workspace+Configuration.swift

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift open source project
 //
-// Copyright (c) 2018-2021 Apple Inc. and the Swift project authors
+// Copyright (c) 2018-2022 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See http://swift.org/LICENSE.txt for license information
@@ -716,7 +716,7 @@ public struct WorkspaceConfiguration {
             prefetchBasedOnResolvedFile: true,
             additionalFileRules: [],
             sharedDependenciesCacheEnabled: true,
-            fingerprintCheckingMode: .warn,
+            fingerprintCheckingMode: .strict,
             sourceControlToRegistryDependencyTransformation: .disabled
         )
     }

Sources/Workspace/Workspace.swift

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift open source project
 //
-// Copyright (c) 2014-2021 Apple Inc. and the Swift project authors
+// Copyright (c) 2014-2022 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See http://swift.org/LICENSE.txt for license information
@@ -476,7 +476,7 @@ public class Workspace {
         additionalFileRules: [FileRuleDescription]? = .none,
         resolverUpdateEnabled: Bool? = .none,
         resolverPrefetchingEnabled: Bool? = .none,
-        resolverFingerprintCheckingMode: FingerprintCheckingMode = .warn,
+        resolverFingerprintCheckingMode: FingerprintCheckingMode = .strict,
         sharedRepositoriesCacheEnabled: Bool? = .none,
         delegate: Delegate? = .none
     ) throws {

Tests/PackageRegistryTests/RegistryClientTests.swift

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift open source project
 //
-// Copyright (c) 2021 Apple Inc. and the Swift project authors
+// Copyright (c) 2021-2022 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See http://swift.org/LICENSE.txt for license information
@@ -372,7 +372,7 @@ final class RegistryClientTests: XCTestCase {
         let registryClient = makeRegistryClient(configuration: configuration,
                                                 httpClient: httpClient,
                                                 fingerprintStorage: fingerprintStorage,
-                                                fingerprintCheckingMode: .strict)
+                                                fingerprintCheckingMode: .strict) // intended for this test; don't change
 
         XCTAssertThrowsError(try registryClient.fetchSourceArchiveChecksum(package: identity, version: version)) { error in
             guard case RegistryError.checksumChanged = error else {
@@ -441,7 +441,7 @@ final class RegistryClientTests: XCTestCase {
         let registryClient = makeRegistryClient(configuration: configuration,
                                                 httpClient: httpClient,
                                                 fingerprintStorage: fingerprintStorage,
-                                                fingerprintCheckingMode: .warn)
+                                                fingerprintCheckingMode: .warn) // intended for this test; don't change
 
         let observability = ObservabilitySystem.makeForTesting()
 
@@ -594,7 +594,7 @@ final class RegistryClientTests: XCTestCase {
         let registryClient = RegistryClient(
             configuration: configuration,
             fingerprintStorage: fingerprintStorage,
-            fingerprintCheckingMode: .strict,
+            fingerprintCheckingMode: .strict, // intended for this test; don't change
             customHTTPClient: httpClient,
             customArchiverProvider: { fileSystem in
                 MockArchiver(handler: { _, from, to, callback in
@@ -677,7 +677,7 @@ final class RegistryClientTests: XCTestCase {
         let registryClient = RegistryClient(
             configuration: configuration,
             fingerprintStorage: fingerprintStorage,
-            fingerprintCheckingMode: .warn,
+            fingerprintCheckingMode: .warn, // intended for this test; don't change
             customHTTPClient: httpClient,
             customArchiverProvider: { fileSystem in
                 MockArchiver(handler: { _, from, to, callback in